Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a dont-break verifyRelease plugin #65

Comments

@boennemann
Copy link
Member

dont-break is a very nice module by @bahmutov, that can detect breaking changes, by running your dependents tests against the current version of your code base.

I'd love to see a semantic-release verifyRelease plugin (just like cracks), but I might not immediately have the time to do it myself.

If you want to give this a shot let me know in this issue and I'm happy to help wherever I can. You can reach me in the semantic-release gitter room, or on Twitter.

@bahmutov
Copy link
Contributor

will consider if I have time. Right now I am thinking of writing a tool that would configure all project-related services: travis, semantic release, david dependencies, codacy in a single command.

@ariporad
Copy link
Contributor

That sounds awesome! And if you're willing, I'd love to help.

Thanks!Ari

On Sun, Aug 23, 2015 at 2:17 PM, Gleb Bahmutov notifications@github.com
wrote:

will consider if I have time. Right now I am thinking of writing a tool that would configure all project-related services: travis, semantic release, david dependencies, codacy in a single command.

Reply to this email directly or view it on GitHub:
#65 (comment)

@boennemann
Copy link
Member Author

@bahmutov Awesome, thank you!

@gajus
Copy link

gajus commented Feb 2, 2016

I don't understand. https://github.com/semantic-release/semantic-release is advertising this as a feature.

Detect breaking changes using your dependents’ test suites: Help out! Implement the dont-break plugin

Oh, no it doesn't. Reading a second time – "Help out!" is supposed to indicate it is an upcoming feature. Thats a bit misleading.

Nevertheless, this would be a deal breaker.

@bahmutov
Copy link
Contributor

I believe my plugin https://github.com/bahmutov/dont-crack already does that

@felixfbecker
Copy link
Contributor

My question would be how to do this before an accidental breaking change is merged into master, i.e. on a PR? Using plain dont-break works, but will not consider whether the commit messages include BREAKING CHANGE

@pvdlg
Copy link
Member

pvdlg commented Jul 23, 2018

@bahmutov do you think you could update https://github.com/bahmutov/dont-crack to the latest semantic-release API?
Or maybe someone in the community would like to make a PR for that?
The we could add it to https://github.com/semantic-release/semantic-release/blob/caribou/docs/extending/plugins-list.md#community-plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment