-
-
Notifications
You must be signed in to change notification settings - Fork 37
Plugin is [NOT] incompatible with PHP 8 #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The solution is the same as #119 : update the allowed version of this plugin to Background: Once the first alpha release for PHP 8.0 came out, the plugin was tested on PHP 8.0 and the PHP version constraints widened to allow installation on PHP 8.0. This change was included in the And as Composer treats minors below Originally posted by @jrfnl in #119 (comment) |
@jrfnl Should we maybe tag a |
@Potherca What do you mean by "explicit composer 2 / php 8" ? Version 0.7.0 already has everything needed for Composer 2 as well as PHP 8 support and both are mentioned in the release changelog. I think more than anything, people get confused because they don't realize that minors below |
With "explicit" I mean "add something in big letter to the README". We already say
We might as well add a mention which Composer and PHP versions are(n't) supported.
Yeah. There is that. We'll have that issue until we put out a 1.0 release but we're not there 100%, yet... |
That's a good idea, but doesn't require a release. As soon as the commit is merged, it will show up in the README here in the repo. |
The release was meant more as a clear marker but I suppose you are correct, and it isn't really needed. I've got time this weekend for this (and the other documentation task). If the |
@Potherca Is it time yet to start hollering insults ? 😝 |
Derp. I seem to have been severely sidetracked with my work for @pipeline-components and @pdsinterop before Xmas and completely forgot to return to this issue afterward 🤦 I'll put it on my worklist and try to bump it to this weekend... Thanks for the reminder! |
A first draft has been added in #132 |
Changes based on review have been added. |
How is this invalid?
This suddenly broke a CI for me. 🤷♀️
Originally posted by @lilithebowman in #119 (comment)
The text was updated successfully, but these errors were encountered: