Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MD034 Error appears underneath wrong link #77

Closed
veleek opened this issue May 27, 2019 · 3 comments
Closed

MD034 Error appears underneath wrong link #77

veleek opened this issue May 27, 2019 · 3 comments
Labels

Comments

@veleek
Copy link

veleek commented May 27, 2019

When you have a paragraph with a bare URL, after a non-bare URL, it will tag the previous bare URL with MD034. For someone who's not familiar with the formatting rules this can cause alot of confusing

image

And the specific error message from the problems pane just to clarify that it is explicitly tagging the first link.

{
	"resource": "README.md",
	"owner": "markdownlint",
	"code": "MD034",
	"severity": 4,
	"message": "MD034/no-bare-urls: Bare URL used",
	"source": "markdownlint",
	"startLineNumber": 11,
	"startColumn": 30,
	"endLineNumber": 11,
	"endColumn": 50
}

This is very similar to #73, but that issue appeared to be talking about some invalid formatted markdown whereas everything is valid in this case so I wanted to bring it up again.

@veleek
Copy link
Author

veleek commented May 27, 2019

VSCode info in case it helps:

Version: 1.34.0 (system setup)
Commit: a622c65b2c713c890fcf4fbf07cf34049d5fe758
Date: 2019-05-15T21:59:37.030Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134

markdownlint extension 0.26.0 installed.

@DavidAnson
Copy link
Owner

Thanks for the detailed information! Your theory is on the right track and I believe this problem is fixed by a change I made that was related to the one you identify. Specifically, this one: DavidAnson/markdownlint#181

That fix will be included in the next update of the extension which should be in a couple of days. I will verify on my machine and let you know later today or tomorrow.

@DavidAnson DavidAnson added the bug label May 28, 2019
@DavidAnson
Copy link
Owner

I confirm this is fixed in the upcoming release of the VS Code extension. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants