Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule MD034 flags URL in Inline code with backticks as "bare url" #181

Closed
xueqing opened this issue Apr 28, 2019 · 6 comments
Closed

rule MD034 flags URL in Inline code with backticks as "bare url" #181

xueqing opened this issue Apr 28, 2019 · 6 comments

Comments

@xueqing
Copy link

xueqing commented Apr 28, 2019

A URL inside of an inline code with backticks is marked as a "bare url" by markdownlint.
My editor is vscode.

Example:
git clone https://github.com/tensorflow/tensorflow.git

markdownlint-no-bare-urls

@DavidAnson DavidAnson added the bug label Apr 28, 2019
@DavidAnson
Copy link
Owner

Thanks, I should be able to look at this soon.

@nschonni
Copy link
Contributor

I think it's actually flagging the # use https://, but I've noticed that the cursor position can sometimes be off on rules in VS Code. EX: Unescaped (MD033) violations usually point to the first element on a line, even if the actual error is with a different element later on in the same line.

@xueqing
Copy link
Author

xueqing commented Apr 29, 2019

Thank you for your explanation! It works for me.

@xueqing
Copy link
Author

xueqing commented Apr 29, 2019

It seems it's my comment problem o(╥﹏╥)o
@DavidAnson

@DavidAnson
Copy link
Owner

That’s great to know, thank you both! I think the error and line number are correct, but the highlighting is wrong. I will leave this issue open to look into that.

Some background, in case you are interested: Some rules identify the range themselves and should usually be correct. There are some cases where the VS Code extension does its own range calculation and those are less reliable because they are based on regular expressions.

@DavidAnson
Copy link
Owner

By the way, I am one failing a test case away from improving MD033 in an upcoming commit. It should handle a few more scenarios and highlight better very soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants