[ddsketch] Add getsum function #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddsketch/ddsketch.go
Outdated
| @@ -181,6 +181,19 @@ func (s *DDSketch) GetMinValue() (float64, error) { | |||
| } | |||
| } | |||
|
|
|||
| // GetSum returns the sum of all values in the sketch. | |||
There was a problem hiding this comment.
Can you add comments as to how accurate that is (similar to what we have in the Java implementation)?
There was a problem hiding this comment.
Added a comment. I haven't found the comment in Java though, so let me know if that works.
There was a problem hiding this comment.
It's there, but I think that works too.
CharlesMasson
approved these changes
Jun 16, 2021
ddsketch/ddsketch.go
Outdated
| @@ -181,6 +181,19 @@ func (s *DDSketch) GetMinValue() (float64, error) { | |||
| } | |||
| } | |||
|
|
|||
| // GetSum returns the sum of all values in the sketch. | |||
There was a problem hiding this comment.
It's there, but I think that works too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function to get the sum of the values in the sketch.