[ddsketch] Add re-mapping function #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddsketch/store/store.go
Outdated
| @@ -26,6 +26,7 @@ type Store interface { | |||
| AddBin(bin Bin) | |||
| AddWithCount(index int, count float64) | |||
| Bins() <-chan Bin | |||
| ForEach(f func(b Bin)) | |||
There was a problem hiding this comment.
Can we make it ForEach(f func(b Bin) bool) to allow early stopping? E.g., we iterate while true is returned.
| // ChangeMapping changes the store to a new mapping. It is not the conversion that minimizes the loss in relative | ||
| // accuracy, but it avoids artefacts like empty bins that make the histograms look bad. | ||
| // scaleFactor allows to scale out / in all values. (changing units for eg) | ||
| func (s *DDSketch) ChangeMapping(newMapping mapping.IndexMapping, positiveStore store.Store, negativeStore store.Store, scaleFactor float64) *DDSketch { |
There was a problem hiding this comment.
Can we make it explicit that negativeStore and positiveStore are meant to be initially empty and distinct store instances? Can we also mention that s is unchanged by the operation and that a new distinct sketch is returned?
CharlesMasson
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds function to be used when converting from one mapping to another one.
It uses bucket overlapping to decide the buckets to assign the values to.
It's not the conversion that minimizes the lost relative accuracy, but it avoids artefacts like empty bins and it produces histograms that look nice.