{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":771925717,"defaultBranch":"main","name":"pg_tracing","ownerLogin":"DataDog","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2024-03-14T07:56:08.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/365230?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715093539.0","currentOid":""},"activityList":{"items":[{"before":"ec771b4c08fcc0c9ec50e8418d911cb02bc929cb","after":null,"ref":"refs/heads/fix-cursor-close","pushedAt":"2024-05-07T15:14:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"}},{"before":"ab2ed546743d8059f3ebe121fb0034752f6be1e6","after":"fef1d1b4be03a1f6674d91dbc3ed086d797a0755","ref":"refs/heads/main","pushedAt":"2024-05-07T15:14:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Fix tracing of close cursor\n\nClosing a cursor will directly call ExecutorFinish. We need to create\nthe top span for those cases.\n\nAlso, as ExecutorEnd will be called, we will try to generate spans from\nplanstate. However, traced planstates won't be available and representing\nplanstate spans for cursor execution doesn't fit our current model. To\nfix this, we disable full query instrumentation for cursors.\n\nFixes #10","shortMessageHtmlLink":"Fix tracing of close cursor"}},{"before":null,"after":"ec771b4c08fcc0c9ec50e8418d911cb02bc929cb","ref":"refs/heads/fix-cursor-close","pushedAt":"2024-05-07T14:52:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Fix tracing of close cursor\n\nClosing a cursor will directly call ExecutorFinish. We need to create\nthe top span for those cases.\n\nAlso, as ExecutorEnd will be called, we will try to generate spans from\nplanstate. However, traced planstates won't be available and representing\nplanstate spans for cursor execution doesn't fit our current model. To\nfix this, we disable full query instrumentation for cursors.\n\nFixes #10","shortMessageHtmlLink":"Fix tracing of close cursor"}},{"before":"871484d0ebd92642f79d920f440b64d20469900d","after":null,"ref":"refs/heads/fix-cursor","pushedAt":"2024-05-07T08:34:19.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"}},{"before":"98cc7c709c5ebaa2084cf30ab7906b6f39281fed","after":"ab2ed546743d8059f3ebe121fb0034752f6be1e6","ref":"refs/heads/main","pushedAt":"2024-05-07T08:34:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Create top span in ExecutorRun hook if needed\n\nWhen fetching an existing cursors, the portal already exists and the\nquery directly starts from ExecutorRun without going through planner,\npost_parse or ExecutorStart. Since top spans were only initialised\nwithin those 3 hooks, cursor fetch wouldn't have a matching top span.\n\nThis commit fixes the issue by creating the top span in ExecutorRun if\nit doesn't exist.\n\nFixes #10","shortMessageHtmlLink":"Create top span in ExecutorRun hook if needed"}},{"before":"1aa486bdaa4f3f936bbe99048d384beb4e74f37e","after":"871484d0ebd92642f79d920f440b64d20469900d","ref":"refs/heads/fix-cursor","pushedAt":"2024-05-07T08:31:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Create top span in ExecutorRun hook if needed\n\nWhen fetching an existing cursors, the portal already exists and the\nquery directly starts from ExecutorRun without going through planner,\npost_parse or ExecutorStart. Since top spans were only initialised\nwithin those 3 hooks, cursor fetch wouldn't have a matching top span.\n\nThis commit fixes the issue by creating the top span in ExecutorRun if\nit doesn't exist.\n\nFixes #10","shortMessageHtmlLink":"Create top span in ExecutorRun hook if needed"}},{"before":"aa7c65bb25404363dcf9a6d2c5630e0d45fff97b","after":"98cc7c709c5ebaa2084cf30ab7906b6f39281fed","ref":"refs/heads/main","pushedAt":"2024-05-07T08:22:06.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Always use span_start_time","shortMessageHtmlLink":"Always use span_start_time"}},{"before":null,"after":"1aa486bdaa4f3f936bbe99048d384beb4e74f37e","ref":"refs/heads/fix-cursor","pushedAt":"2024-05-07T08:21:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Create top span in ExecutorRun hook if needed\n\nWhen fetching an existing cursors, the portal already exists and the\nquery directly starts from ExecutorRun without going through planner,\npost_parse or ExecutorStart. Since top spans were only initialised\nwithin those 3 hooks, cursor fetch wouldn't have a matching top span.\n\nThis commit fixes the issue by creating the top span in ExecutorRun if\nit doesn't exist.\n\nFixes #10","shortMessageHtmlLink":"Create top span in ExecutorRun hook if needed"}},{"before":"2939ece0b9c85f5a020e24846ab482042cb77a58","after":"aa7c65bb25404363dcf9a6d2c5630e0d45fff97b","ref":"refs/heads/main","pushedAt":"2024-05-07T06:46:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Fix typos","shortMessageHtmlLink":"Fix typos"}},{"before":"9c124d94e757fc91c9ecb95156942195455ded38","after":"2939ece0b9c85f5a020e24846ab482042cb77a58","ref":"refs/heads/main","pushedAt":"2024-05-07T06:26:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Misc typo fixes and cosmetic cleanup in comments (#8)","shortMessageHtmlLink":"Misc typo fixes and cosmetic cleanup in comments (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2280500009\" data-permission-text=\"Title is private\" data-url=\"https://github.com/DataDog/pg_tracing/issues/8\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/DataDog/pg_tracing/pull/8/hovercard\" href=\"https://github.com/DataDog/pg_tracing/pull/8\">#8</a>)"}},{"before":"3076d36986e68aa8acef7731edd0fb207c414b2f","after":"9c124d94e757fc91c9ecb95156942195455ded38","ref":"refs/heads/main","pushedAt":"2024-04-25T09:01:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Update README","shortMessageHtmlLink":"Update README"}},{"before":"9c124d94e757fc91c9ecb95156942195455ded38","after":null,"ref":"refs/heads/update-readme","pushedAt":"2024-04-25T09:00:43.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"}},{"before":null,"after":"9c124d94e757fc91c9ecb95156942195455ded38","ref":"refs/heads/update-readme","pushedAt":"2024-04-25T09:00:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Update README","shortMessageHtmlLink":"Update README"}},{"before":"8ecd15af95d5cc8c7f4029378650cc3f52e1aed5","after":"3076d36986e68aa8acef7731edd0fb207c414b2f","ref":"refs/heads/main","pushedAt":"2024-04-23T09:23:34.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Fix test for subplan end","shortMessageHtmlLink":"Fix test for subplan end"}},{"before":"db3b8f7a63007d2d1ba266f03962bb706112a7d7","after":"8ecd15af95d5cc8c7f4029378650cc3f52e1aed5","ref":"refs/heads/main","pushedAt":"2024-04-19T07:34:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Handle top spans with empty query string\n\nSome functions will only store the query tree and no source in pg_proc.\nWhen those are called, the query text will be empty. We don't have\ninformation available from the hook so just skip setting an operation\nname.","shortMessageHtmlLink":"Handle top spans with empty query string"}},{"before":"bda1bcb26ea2a5f016be0b5b9d43895cf19687b9","after":"db3b8f7a63007d2d1ba266f03962bb706112a7d7","ref":"refs/heads/main","pushedAt":"2024-04-18T08:59:51.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Use child's end as span_end for special nodes","shortMessageHtmlLink":"Use child's end as span_end for special nodes"}},{"before":"bda1bcb26ea2a5f016be0b5b9d43895cf19687b9","after":null,"ref":"refs/heads/pg15-support","pushedAt":"2024-04-17T09:21:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"}},{"before":"b6adb3a1e38b05048243c5fb0ab4e4d28d43d7e6","after":"bda1bcb26ea2a5f016be0b5b9d43895cf19687b9","ref":"refs/heads/main","pushedAt":"2024-04-17T09:21:08.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Limit depth for subplans check to avoid flakiness","shortMessageHtmlLink":"Limit depth for subplans check to avoid flakiness"}},{"before":"1344fe5afde6c6bfc362a4e393fa9b080f1cd089","after":"bda1bcb26ea2a5f016be0b5b9d43895cf19687b9","ref":"refs/heads/pg15-support","pushedAt":"2024-04-17T09:16:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Limit depth for subplans check to avoid flakiness","shortMessageHtmlLink":"Limit depth for subplans check to avoid flakiness"}},{"before":null,"after":"1344fe5afde6c6bfc362a4e393fa9b080f1cd089","ref":"refs/heads/pg15-support","pushedAt":"2024-04-17T09:10:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Add pg15 to test matrix","shortMessageHtmlLink":"Add pg15 to test matrix"}},{"before":"5572fdfd18f0aa3eb61ef525d5830c23a174abf7","after":"b6adb3a1e38b05048243c5fb0ab4e4d28d43d7e6","ref":"refs/heads/main","pushedAt":"2024-04-16T09:51:59.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Add test for init plan traces","shortMessageHtmlLink":"Add test for init plan traces"}},{"before":"dfda156b78b3a0833000c27eb957b17bedd0c631","after":null,"ref":"refs/heads/fix-top-span-end","pushedAt":"2024-04-15T07:40:29.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"}},{"before":"bdce1058dbeee94ef441aa02bc0eb2ab390e199a","after":"5572fdfd18f0aa3eb61ef525d5830c23a174abf7","ref":"refs/heads/main","pushedAt":"2024-04-15T07:40:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Use parent planstate as span end for top level spans (#5)\n\nTop spans end are currently ended at the end of the parent's ExecutorRun\r\nwhile nodes will rely on query instrumentation. This can lead to a\r\nsituation where a node with nested queries like ProjectSet is shorter\r\nthan its children.\r\n\r\nWe already use traced_planstate to correctly assign parent for a nested\r\ntop span. We will keep track of the traced_planstate in the span and use\r\nit to when ending the top span.","shortMessageHtmlLink":"Use parent planstate as span end for top level spans (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2224741950\" data-permission-text=\"Title is private\" data-url=\"https://github.com/DataDog/pg_tracing/issues/5\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/DataDog/pg_tracing/pull/5/hovercard\" href=\"https://github.com/DataDog/pg_tracing/pull/5\">#5</a>)"}},{"before":"367454ba44354e3be76e5c4dc14e7270c2e99cbc","after":"dfda156b78b3a0833000c27eb957b17bedd0c631","ref":"refs/heads/fix-top-span-end","pushedAt":"2024-04-15T07:37:12.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Use parent planstate as span end for top level spans\n\nTop spans end are currently ended at the end of the parent's ExecutorRun\nwhile nodes will rely on query instrumentation. This can lead to a\nsituation where a node with nested queries like ProjectSet is shorter\nthan its children.\n\nWe already use traced_planstate to correctly assign parent for a nested\ntop span. We will keep track of the traced_planstate in the span and use\nit to when ending the top span.","shortMessageHtmlLink":"Use parent planstate as span end for top level spans"}},{"before":"2b730434bf67d75f09d8aa637b51b7be75c885b3","after":"367454ba44354e3be76e5c4dc14e7270c2e99cbc","ref":"refs/heads/fix-top-span-end","pushedAt":"2024-04-15T07:30:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Use parent planstate as span end for top level spans\n\nTop spans end are currently ended at the end of the parent's ExecutorRun\nwhile nodes will rely on query instrumentation. This can lead to a\nsituation where a node with nested queries like ProjectSet is shorter\nthan its children.\n\nWe already use traced_planstate to correctly assign parent for a nested\ntop span. We will keep track of the traced_planstate in the span and use\nit to when ending the top span.","shortMessageHtmlLink":"Use parent planstate as span end for top level spans"}},{"before":"bdce1058dbeee94ef441aa02bc0eb2ab390e199a","after":null,"ref":"refs/heads/fix-ci","pushedAt":"2024-04-05T12:01:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"}},{"before":"5974409940c3b193f831548afe5354acbe20d0e7","after":"bdce1058dbeee94ef441aa02bc0eb2ab390e199a","ref":"refs/heads/main","pushedAt":"2024-04-05T12:01:03.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Filter parent state candidate using exec nested level","shortMessageHtmlLink":"Filter parent state candidate using exec nested level"}},{"before":"ca45fa15851b4edf1aaa75f505573a5721dcc276","after":"bdce1058dbeee94ef441aa02bc0eb2ab390e199a","ref":"refs/heads/fix-ci","pushedAt":"2024-04-05T11:50:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Filter parent state candidate using exec nested level","shortMessageHtmlLink":"Filter parent state candidate using exec nested level"}},{"before":"599b73b2183e1ef81bac27d414d7e7a2d5486629","after":"ca45fa15851b4edf1aaa75f505573a5721dcc276","ref":"refs/heads/fix-ci","pushedAt":"2024-04-05T08:29:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Filter parent state candidate using exec nested level","shortMessageHtmlLink":"Filter parent state candidate using exec nested level"}},{"before":"9e8b2501d77b755c0a3b0e94af1850172c78bd2e","after":"599b73b2183e1ef81bac27d414d7e7a2d5486629","ref":"refs/heads/fix-ci","pushedAt":"2024-04-05T08:19:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bonnefoa","name":"Anthonin Bonnefoy","path":"/bonnefoa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30333?s=80&v=4"},"commit":{"message":"Filter parent state candidate using exec nested level","shortMessageHtmlLink":"Filter parent state candidate using exec nested level"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQ7mSqwA","startCursor":null,"endCursor":null}},"title":"Activity · DataDog/pg_tracing"}