Tag spans from external services #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
commented
Jan 23, 2020
| @@ -39,6 +40,9 @@ def process(span, event, _id, payload) | |||
| span.resource = payload.fetch(:sql) | |||
| span.span_type = Datadog::Ext::SQL::TYPE | |||
|
|
|||
| # Tag as an external peer service | |||
| span.set_tag(Datadog::Ext::Integration::TAG_PEER_SERVICE, span.service) | |||
There was a problem hiding this comment.
I've deliberated if the peer service tag deserves its own first-class module, like analytics sampling rate has, but couldn't convince myself that having that module would add enough value to compensate for the creation of a trivial new file for us to maintain.
It would have simpler logic than analytics sampling rate: it would boil down to a getter and a setter on the already created constant Datadog::Ext::Integration::TAG_PEER_SERVICE.
I've leaned towards considering the constant, Datadog::Ext::Integration::TAG_PEER_SERVICE, as the main feature anchor for peer services and use it where needed, instead of creating a module.
But I'm still very much open to suggestions.
ericmustin
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tags all spans created by
ddtracethat represent work performed by a system outside of the application being traced.This tag will be useful in the future, to allow for better grouping of traces belonging to different services.