Extract ActionPack from Rails #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
integrations
brettlangdon
approved these changes
Aug 23, 2019
delner
force-pushed
the
refactor/extract_actionview_from_rails
branch
from
29a1054
to
322086b
Compare
delner
force-pushed
the
refactor/extract_actionpack_from_rails
branch
from
c121dae
to
173f540
Compare
delner
changed the base branch from
refactor/extract_actionview_from_rails
to
0.27-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a next step towards simplifying the Rails integration, this pull request extracts all the ActionPack instrumentation from the Rails integration into a new
action_packintegration. This new integration is automatically activated by the Rails integration, so users with use :rails should see no change.Changes in this PR are dependent on #762. After that's merged, rebase and merge this to the dev branch.