Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ruby 1.9 support from core #791

Merged
merged 3 commits into from Aug 15, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented Aug 12, 2019

As a follow up to deprecating Ruby 1.9 support, this pull request removes 1.9 compatible code in the tracer core in favor of improved implementations (e.g. replace method rewrites with prepend, etc.) Integrations using such 1.9 patterns will be upgraded in other PRs following this one.

Once merged, ddtrace will require Ruby 2.0+.

@delner delner added core Involves Datadog core libraries breaking-change Involves a breaking change dev/refactor Involves refactoring existing components labels Aug 12, 2019
@delner delner added this to the 0.27.0 milestone Aug 12, 2019
@delner delner self-assigned this Aug 12, 2019
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@delner delner force-pushed the refactor/remove_1.9_support_from_core branch from 41af9d9 to 468c83f Compare August 14, 2019 21:41
@delner delner merged commit ac6815a into 0.27-dev Aug 15, 2019
@delner delner deleted the refactor/remove_1.9_support_from_core branch August 15, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Involves a breaking change core Involves Datadog core libraries dev/refactor Involves refactoring existing components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants