Extract ActionView from Rails #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
integrations
delner
force-pushed
the
refactor/extract_actionview_from_rails
branch
2 times, most recently
from
6928012
to
75e9220
Compare
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
from
2224b72
to
af16bae
Compare
delner
force-pushed
the
refactor/extract_actionview_from_rails
branch
from
75e9220
to
1befbc6
Compare
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
from
af16bae
to
3769229
Compare
delner
force-pushed
the
refactor/extract_actionview_from_rails
branch
from
12c95ff
to
3ca366a
Compare
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
3 times, most recently
from
e4a8967
to
2c3d927
Compare
delner
force-pushed
the
refactor/extract_actionview_from_rails
branch
from
3ca366a
to
2d893f9
Compare
|
Reworked this a little bit:
Might want to consider adding some tests for using ActionView in a standalone way in the future, but for now the existing Rails tests should be sufficient. Should be ready for review @brettlangdon |
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
from
2c3d927
to
df6ad3d
Compare
delner
force-pushed
the
refactor/extract_actionview_from_rails
branch
from
2d893f9
to
6dcbe4c
Compare
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
from
df6ad3d
to
9414b9f
Compare
delner
force-pushed
the
refactor/extract_actionview_from_rails
branch
2 times, most recently
from
7d270cb
to
3ec2bde
Compare
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
from
9414b9f
to
9bd69e7
Compare
delner
force-pushed
the
refactor/extract_actionview_from_rails
branch
2 times, most recently
from
4691e6a
to
29a1054
Compare
brettlangdon
approved these changes
Sep 3, 2019
delner
force-pushed
the
refactor/extract_actionview_from_rails
branch
from
29a1054
to
322086b
Compare
delner
changed the base branch from
refactor/extract_activesupport_from_rails
to
0.27-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a next step towards simplifying the Rails integration, this pull request extracts all the ActionView instrumentation from the Rails integration into a new
action_viewintegration. This new integration is automatically activated by the Rails integration, so users withuse :railsshould see no change.Changes in this PR are dependent on #747. After that's merged, rebase and merge this to the dev branch.