Extract ActiveSupport from Rails #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
integrations
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
from
b4425dd
to
33c8fd3
Compare
delner
commented
May 6, 2019
| @@ -93,6 +79,18 @@ def call_pipeline(*args, &block) | |||
|
|
|||
| response | |||
| end | |||
|
|
|||
| def datadog_pin | |||
There was a problem hiding this comment.
This fixes a bug where a Redis client initialized before being patched wouldn't receive trace configuration, and thus wouldn't send traces. By lazy initializing the Pin, we can ensure it's available at trace time.
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
from
5717195
to
2224b72
Compare
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
from
305dd59
to
2224b72
Compare
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
from
2224b72
to
af16bae
Compare
brettlangdon
approved these changes
May 30, 2019
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
from
af16bae
to
3769229
Compare
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
from
3769229
to
15ba4f9
Compare
|
Reworked this one a little bit:
This probably warrants another review @brettlangdon. |
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
2 times, most recently
from
e4a8967
to
2c3d927
Compare
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
2 times, most recently
from
df6ad3d
to
9414b9f
Compare
delner
force-pushed
the
refactor/extract_activesupport_from_rails
branch
from
9414b9f
to
9bd69e7
Compare
brettlangdon
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step towards simplifying the Rails integration, this pull request extracts all the ActiveSupport instrumentation from the Rails integration into a new
active_supportintegration. This new integration is automatically activated by the Rails integration, so users withuse :railsshould see no change.Users who don't use Rails, but do use ActiveSupport should now be able to activate instrumentation for this gem without the Rails integration.