Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed tracing: Typhoeus support #527

Closed
guizmaii opened this issue Aug 28, 2018 · 7 comments
Closed

Distributed tracing: Typhoeus support #527

guizmaii opened this issue Aug 28, 2018 · 7 comments
Assignees
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations
Projects
Milestone

Comments

@guizmaii
Copy link
Contributor

guizmaii commented Aug 28, 2018

Hi,

We're using https://github.com/typhoeus/typhoeus to make our HTTP calls. Is it possible for you to support this lib ?

Jules

@delner delner self-assigned this Sep 10, 2018
@delner delner added integrations Involves tracing integrations feature-request A request for a new feature or change to an existing one community Was opened by a community member labels Sep 10, 2018
@delner
Copy link
Contributor

delner commented Sep 10, 2018

Hey @guizmaii , sorry for the late reply! I'll take a look at this and try to get it on our schedule. Thanks for the suggestion!

@che-burashco
Copy link

@delner Is there any way you could take a look at #778? We (Wealthsimple) are facing the same issue as Jules and @al-kudryavtsev has done some work to add the support for Ethon

@delner
Copy link
Contributor

delner commented Jul 12, 2019

@che-burashco Yeah, no problem, I'm going to try to get the priority bumped up on this. The PR looks more complete since last I saw it, so I'll check there if its ready for a review.

One thing that isn't clear to me; would that PR sufficiently cover the Typhoeus support requested here? I'm not familiar with the relationship between Typhoeus vs Ethon other than they stem from the same org.

@delner
Copy link
Contributor

delner commented Jul 15, 2019

@guizmaii @che-burashco I was discussing #778 with @al-kudryavtsev and it sounds like that PR will add tracing to Ethon which, by proxy, should implement some basic tracing for Typhoeus, albeit not specialized instrumentation or details specific to Typhoeus. Tracing would be activated with c.use :ethon.

Would that PR be sufficient to address (close) this issue? Or are there other features you would consider necessary to consider this done?

@che-burashco
Copy link

That would be enough for us

@guizmaii
Copy link
Contributor Author

Hi everyone,

I'm not working anymore with Ruby so I can't help you here. HF :)

@delner
Copy link
Contributor

delner commented Sep 5, 2019

We released Ethon tracing support with version 0.27.0, which should cover Typhoeus. Going to close this issue, but feel free to check that out, and re-open/comment here if need be!

@delner delner closed this as completed Sep 5, 2019
@delner delner added this to the 0.27.0 milestone Sep 5, 2019
@delner delner added this to Resolved/Closed in Active work Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations
Projects
Active work
  
Resolved/Closed
Development

No branches or pull requests

3 participants