Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable benchmarks in CI #1184

Merged
merged 1 commit into from Sep 22, 2020
Merged

Disable benchmarks in CI #1184

merged 1 commit into from Sep 22, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Sep 21, 2020

With the introduction of new benchmarks, our CI builds have got very slow.

Benchmarks will not yield representative numbers when running in a shared cloud environment, like CircleCI for example.

We are in the process of executing our benchmarks in a dedicated environment, using internal infrastructure.

This PR removes benchmarks from our CI runs, as they are not providing much value when executed alongside tests.

@marcotc marcotc added the dev/testing Involves testing processes (e.g. RSpec) label Sep 21, 2020
@marcotc marcotc requested a review from a team September 21, 2020 21:56
@marcotc marcotc self-assigned this Sep 21, 2020
@marcotc marcotc merged commit d34b5b7 into master Sep 22, 2020
@marcotc marcotc deleted the test/disable-benchamarks-in-ci branch September 22, 2020 16:40
@marcotc marcotc added this to the 0.41.0 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants