Fix Span#pretty_print for empty duration #1183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures
Span#pretty_print
is able to handle all valid values it prints.The required changes were around the span's timing values.
This PR also adds a smoke test to ensure
Span#pretty_print
at least outputs a string without any errors.The main error we stated seeing
was actually addressed in a previous PR by @ericmustin, but I remove a few of the safe-guard
rescue
statements fromdef duration
when making changes to improve performance. I seek forgiveness with this PR 馃檱.