Correct tracer buffer metric counting #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
force-pushed
the
metrics/fix-buffer-count
branch
from
fd5fa32
to
b0beaa7
Compare
|
@ericmustin, I rebased, since this PR was previously not based on master. |
ericmustin
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our health metrics counters for the TraceBuffer were not consistent among each other.
Before this change
buffer_accepted_lengthshad the current number of spans in the buffer, but this value is already covered byqueue_spans. The object was forbuffer_accepted_lengthsto have the total cumulative number of spans pushed into the buffer.All values should be consistent now with this PR:
queue_accepted,queue_accepted_lengths,queue_droppedqueue_max_length,queue_spans,queue_length