Avoid *_any_instance_of when running tests with parallelism #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
test/fix-parallelism-with-_any_instance_of
to
master
September 18, 2020 21:16
marcotc
deleted the
test/fix-parallelism-with-_any_instance_of-2-the-test-part
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1177, for support for clean tracer shutdown/restart (merged)Fixes flaky tests when running our tracer with JRuby, like this one.
This happens because, during testing, we collect spans from our tracer by executing
allow_any_instance_of(Datadog::Tracer).to receive(:write).This setup works fine on CRuby, but JRuby encounters a scenario where two calls to
tracer.write(trace)try to be executed at the same time, but only one makes it through.This PR changes the setup to use single object mocks, which reliability works now.
I've searched our test suite, and this is the only use of
*_any_instance_ofthat can be affected by this issue, as it's the only one that mocks a method that can be called from multiple threads.All our uses of
*_any_instance_ofin single tests do not involve concurrency, and are thus safe.