Allow tracer components to be cleanly restarted after shutdown #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,7 +56,10 @@ def logger | |||
| end | |||
|
|
|||
| def shutdown! | |||
| components.shutdown! if instance_variable_defined?(:@components) && @components | |||
| if instance_variable_defined?(:@components) && @components | |||
There was a problem hiding this comment.
should this change be in a different PR?
There was a problem hiding this comment.
This is the important change, I updated the description of the PR to match.
|
I think a commit slipped in here unrelated, otherwise lgtm and thanks for tracking this down, these flaky tests have been killing us |
marcotc
changed the title
|
@ericmustin I removed the test fix, and kept the important change regarding tracer shutdown. |
marcotc
added
core
ericmustin
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have inconsistent behaviour with
Configuration#shutdown!where we shut down our components object (components.shutdown!), but we keep its lingering instance in an instance variable (@components), with partially living references.This prevented us from ever being able to restart the tracer, only ever returning dirty instances of the tracer on every call to
Datadog.tracerafter a shutdown.This PR now allows the tracer components to be cleanly
shutdown!and restarted, without lingering references.