Disable coverage report for benchmarks #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
approved these changes
Sep 16, 2020
|
Our benchmarks won't cover everything, only parts that require special
attention.
It's there any reason you like to benchmark everything?
…On Wed, Sep 16, 2020, 9:34 AM Brett Langdon ***@***.***> wrote:
***@***.**** approved this pull request.
but how will we know if our benchmarks cover everything?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1176 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEOOTYTYROSP67CUFQQXCTSGC5HDANCNFSM4RN2JWLA>
.
|
ericmustin
approved these changes
Sep 16, 2020
@marcotc sorry, I should have put |
|
@brettlangdon Poe's law |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collecting code coverage during benchmarks slows down the execution.
This PR disables coverage collection on all tests run from a benchmark directory.