Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Official DD-tracer Document should be updated to point out none OF DBM option is replaced with value disabled #4139

Open
eugeneYWang opened this issue Mar 5, 2024 · 2 comments · May be fixed by #4140
Open

Official DD-tracer Document should be updated to point out none OF DBM option is replaced with value disabled #4139

eugeneYWang opened this issue Mar 5, 2024 · 2 comments · May be fixed by #4140

Comments

@eugeneYWang
Copy link

dd-trace-js/packages/dd-trace/src/plugins/database.js

Line 54 in c9af707

if (mode === 'disabled') {

This line is actually using disabled, not none.

While the documentation said

none mode disables propagation and does not send any information from applications.
@eugeneYWang
Copy link
Author

eugeneYWang commented Mar 5, 2024 •
edited

attaching the URL of official DD-trace documentation where suggested others to use none. And this is wrong since many versions ago.

https://docs.datadoghq.com/database_monitoring/connect_dbm_and_apm/?tab=nodejs

@eugeneYWang
Copy link
Author

the impact of this error will cause actual SQL statement to be overridden as empty and it cause mysql library to complain EMTPY query and mysql2 connection to hang until connections are disconnected by MYSQL.

@eugeneYWang eugeneYWang linked a pull request Mar 5, 2024 that will close this issue
Open
2 tasks
kai-thomas-datadog added a commit to DataDog/documentation that referenced this issue Mar 6, 2024
@kai-thomas-datadog
none mode should be disabled mode
63c39be 
DataDog/dd-trace-js#4140
DataDog/dd-trace-js#4139

this is an issue for customer since a few versions ago, and the doc is causing confusion and errors.
@kai-thomas-datadog kai-thomas-datadog mentioned this issue Mar 6, 2024
Merged
1 task
cswatt pushed a commit to DataDog/documentation that referenced this issue Mar 6, 2024
@kai-thomas-datadog
none mode should be disabled mode (#22090)
f2aa3bd 
DataDog/dd-trace-js#4140
DataDog/dd-trace-js#4139

this is an issue for customer since a few versions ago, and the doc is causing confusion and errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invalid DBM Propagation Mode breaking mysql/mysql2 plugin choult/dd-trace-js
1 participant
@eugeneYWang