Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly name bulkWrite operations in the mongo plugin #4073

Open
vanstinator opened this issue Feb 16, 2024 · 0 comments
Open

Properly name bulkWrite operations in the mongo plugin #4073

vanstinator opened this issue Feb 16, 2024 · 0 comments

Comments

@vanstinator
Copy link
Contributor

The current mongo plugin instruments the low level driver to determine the operation type.

I think there's probably 2 ways to go about this:

  • in the instrumentation library use a best-effort analysis of the cmd array size to determine if the query is bulkWrite
  • wrap the bulkWrite function in the higher level interface of the driver and generate a span for it, or pass down the details to the instrumentation plugin to use when generating the resource name

Delineating bulkWrite from the underlying operations is interesting because it provides an indicator to anyone looking at spans that this span may be driving heavier database IOPS, and currently bulkWrites masquerade as flat update, delete, insert type resources.

@vanstinator vanstinator changed the title Support bulkWrite operations in the mongo plugin Properly name bulkWrite operations in the mongo plugin Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant