Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Selenium instrumentation to avoid trying to set cookies for about:blank and other similar pages #6973

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix Selenium instrumentation to avoid trying to set cookies for about:blank and other similar pages #6973

merged 1 commit into from
May 3, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Apr 30, 2024 •
edited by jira bot

What Does This Do

Updates Selenium instrumentation to avoid setting cookies for pages whose URL cannot be parsed (about:blank is one example of such page).

Motivation

Some Selenium tests explicitly open about:blank before starting a test case.
Trying to set a cookie for this page will lead to a Selenium driver exception.

Additional Notes

Selenium instrumentation adds cookies for loaded pages in order to integrate with DD RUM (if the page has RUM instrumentation configured, RUM will use the cookie to establish correspondence between a RUM session and a CI Visibility test case).

Jira ticket: CIVIS-9921

@nikita-tkachenko-datadog nikita-tkachenko-datadog added type: bug comp: ci visibility Continuous Integration Visibility labels Apr 30, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog linked an issue Apr 30, 2024 that may be closed by this pull request
BUG: dd-trace-java with version 1.33.0 causes InvalidCookieDomainException. In 1.32.0 works fine. #6938
Closed
@pr-commenter
Copy link

pr-commenter bot commented Apr 30, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/selenium-about-blank
git_commit_date 1714472597 1714477123
git_commit_sha 2b0502c 948cedc
release_version 1.34.0-SNAPSHOT~2b0502cacf 1.34.0-SNAPSHOT~948cedc714
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714480407 1714480407
ci_job_id 500672056 500672056
ci_pipeline_id 33242272 33242272
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~948cedc714, baseline=1.34.0-SNAPSHOT~2b0502cacf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078546
Total [baseline] (10.38 s) : 0, 10380126
Agent [candidate] (1.078 s) : 0, 1077945
Total [candidate] (10.372 s) : 0, 10371872
section appsec
Agent [baseline] (1.194 s) : 0, 1193950
Total [baseline] (10.53 s) : 0, 10530066
Agent [candidate] (1.19 s) : 0, 1189705
Total [candidate] (10.475 s) : 0, 10475093
section iast
Agent [baseline] (1.206 s) : 0, 1205677
Total [baseline] (10.754 s) : 0, 10754084
Agent [candidate] (1.205 s) : 0, 1205268
Total [candidate] (10.762 s) : 0, 10761724
section profiling
Agent [baseline] (1.267 s) : 0, 1266500
Total [baseline] (10.578 s) : 0, 10578334
Agent [candidate] (1.267 s) : 0, 1267357
Total [candidate] (10.616 s) : 0, 10615645
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.194 s 115.404 ms (10.7%)
Agent iast 1.206 s 127.131 ms (11.8%)
Agent profiling 1.267 s 187.955 ms (17.4%)
Total tracing 10.38 s -
Total appsec 10.53 s 149.94 ms (1.4%)
Total iast 10.754 s 373.958 ms (3.6%)
Total profiling 10.578 s 198.208 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.19 s 111.76 ms (10.4%)
Agent iast 1.205 s 127.322 ms (11.8%)
Agent profiling 1.267 s 189.412 ms (17.6%)
Total tracing 10.372 s -
Total appsec 10.475 s 103.221 ms (1.0%)
Total iast 10.762 s 389.852 ms (3.8%)
Total profiling 10.616 s 243.773 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~948cedc714, baseline=1.34.0-SNAPSHOT~2b0502cacf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (677.071 ms) : 0, 677071
BytebuddyAgent [candidate] (675.617 ms) : 0, 675617
GlobalTracer [baseline] (309.644 ms) : 0, 309644
GlobalTracer [candidate] (309.799 ms) : 0, 309799
AppSec [baseline] (49.208 ms) : 0, 49208
AppSec [candidate] (49.611 ms) : 0, 49611
Remote Config [baseline] (653.322 µs) : 0, 653
Remote Config [candidate] (657.51 µs) : 0, 658
Telemetry [baseline] (7.507 ms) : 0, 7507
Telemetry [candidate] (7.58 ms) : 0, 7580
section appsec
BytebuddyAgent [baseline] (698.448 ms) : 0, 698448
BytebuddyAgent [candidate] (696.349 ms) : 0, 696349
GlobalTracer [baseline] (292.139 ms) : 0, 292139
GlobalTracer [candidate] (291.945 ms) : 0, 291945
AppSec [baseline] (149.946 ms) : 0, 149946
AppSec [candidate] (148.949 ms) : 0, 148949
Remote Config [baseline] (635.372 µs) : 0, 635
Remote Config [candidate] (617.659 µs) : 0, 618
Telemetry [baseline] (8.598 ms) : 0, 8598
Telemetry [candidate] (7.892 ms) : 0, 7892
IAST [baseline] (19.407 ms) : 0, 19407
IAST [candidate] (19.14 ms) : 0, 19140
section iast
BytebuddyAgent [baseline] (799.14 ms) : 0, 799140
BytebuddyAgent [candidate] (799.014 ms) : 0, 799014
GlobalTracer [baseline] (289.294 ms) : 0, 289294
GlobalTracer [candidate] (289.897 ms) : 0, 289897
AppSec [baseline] (50.366 ms) : 0, 50366
AppSec [candidate] (50.333 ms) : 0, 50333
Remote Config [baseline] (580.828 µs) : 0, 581
Remote Config [candidate] (1.471 ms) : 0, 1471
Telemetry [baseline] (6.623 ms) : 0, 6623
Telemetry [candidate] (6.677 ms) : 0, 6677
IAST [baseline] (25.155 ms) : 0, 25155
IAST [candidate] (23.248 ms) : 0, 23248
section profiling
BytebuddyAgent [baseline] (677.008 ms) : 0, 677008
BytebuddyAgent [candidate] (677.187 ms) : 0, 677187
GlobalTracer [baseline] (379.929 ms) : 0, 379929
GlobalTracer [candidate] (380.001 ms) : 0, 380001
AppSec [baseline] (49.965 ms) : 0, 49965
AppSec [candidate] (50.12 ms) : 0, 50120
Remote Config [baseline] (710.112 µs) : 0, 710
Remote Config [candidate] (704.265 µs) : 0, 704
Telemetry [baseline] (7.464 ms) : 0, 7464
Telemetry [candidate] (7.526 ms) : 0, 7526
ProfilingAgent [baseline] (95.146 ms) : 0, 95146
ProfilingAgent [candidate] (95.404 ms) : 0, 95404
Profiling [baseline] (95.17 ms) : 0, 95170
Profiling [candidate] (95.428 ms) : 0, 95428
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~948cedc714, baseline=1.34.0-SNAPSHOT~2b0502cacf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080505
Total [baseline] (8.546 s) : 0, 8545752
Agent [candidate] (1.081 s) : 0, 1081139
Total [candidate] (8.54 s) : 0, 8539970
section iast
Agent [baseline] (1.196 s) : 0, 1196165
Total [baseline] (9.022 s) : 0, 9021668
Agent [candidate] (1.198 s) : 0, 1197562
Total [candidate] (8.971 s) : 0, 8971249
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.213 s) : 0, 1212813
Total [baseline] (9.009 s) : 0, 9008553
Agent [candidate] (1.216 s) : 0, 1216055
Total [candidate] (8.994 s) : 0, 8994314
section iast_TELEMETRY_OFF
Agent [baseline] (1.203 s) : 0, 1203272
Total [baseline] (8.989 s) : 0, 8988523
Agent [candidate] (1.21 s) : 0, 1209722
Total [candidate] (9.015 s) : 0, 9014604
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.196 s 115.66 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.213 s 132.308 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.203 s 122.767 ms (11.4%)
Total tracing 8.546 s -
Total iast 9.022 s 475.916 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.009 s 462.801 ms (5.4%)
Total iast_TELEMETRY_OFF 8.989 s 442.771 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.198 s 116.423 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.216 s 134.916 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.21 s 128.584 ms (11.9%)
Total tracing 8.54 s -
Total iast 8.971 s 431.279 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.994 s 454.343 ms (5.3%)
Total iast_TELEMETRY_OFF 9.015 s 474.634 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~948cedc714, baseline=1.34.0-SNAPSHOT~2b0502cacf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (676.835 ms) : 0, 676835
BytebuddyAgent [candidate] (677.322 ms) : 0, 677322
GlobalTracer [baseline] (310.913 ms) : 0, 310913
GlobalTracer [candidate] (311.266 ms) : 0, 311266
AppSec [baseline] (49.678 ms) : 0, 49678
AppSec [candidate] (49.844 ms) : 0, 49844
Remote Config [baseline] (680.389 µs) : 0, 680
Remote Config [candidate] (664.88 µs) : 0, 665
Telemetry [baseline] (7.708 ms) : 0, 7708
Telemetry [candidate] (7.582 ms) : 0, 7582
section iast
BytebuddyAgent [baseline] (792.045 ms) : 0, 792045
BytebuddyAgent [candidate] (793.645 ms) : 0, 793645
GlobalTracer [baseline] (287.455 ms) : 0, 287455
GlobalTracer [candidate] (287.809 ms) : 0, 287809
AppSec [baseline] (50.941 ms) : 0, 50941
AppSec [candidate] (48.846 ms) : 0, 48846
IAST [baseline] (24.267 ms) : 0, 24267
IAST [candidate] (24.789 ms) : 0, 24789
Remote Config [baseline] (631.271 µs) : 0, 631
Remote Config [candidate] (669.188 µs) : 0, 669
Telemetry [baseline] (6.687 ms) : 0, 6687
Telemetry [candidate] (7.424 ms) : 0, 7424
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.977 ms) : 0, 803977
BytebuddyAgent [candidate] (805.584 ms) : 0, 805584
GlobalTracer [baseline] (290.918 ms) : 0, 290918
GlobalTracer [candidate] (291.848 ms) : 0, 291848
AppSec [baseline] (53.131 ms) : 0, 53131
AppSec [candidate] (50.952 ms) : 0, 50952
IAST [baseline] (21.944 ms) : 0, 21944
IAST [candidate] (23.162 ms) : 0, 23162
Remote Config [baseline] (579.856 µs) : 0, 580
Remote Config [candidate] (1.322 ms) : 0, 1322
Telemetry [baseline] (7.54 ms) : 0, 7540
Telemetry [candidate] (8.423 ms) : 0, 8423
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.447 ms) : 0, 796447
BytebuddyAgent [candidate] (799.724 ms) : 0, 799724
GlobalTracer [baseline] (289.523 ms) : 0, 289523
GlobalTracer [candidate] (292.292 ms) : 0, 292292
AppSec [baseline] (50.861 ms) : 0, 50861
AppSec [candidate] (53.286 ms) : 0, 53286
IAST [baseline] (22.527 ms) : 0, 22527
IAST [candidate] (21.735 ms) : 0, 21735
Remote Config [baseline] (585.812 µs) : 0, 586
Remote Config [candidate] (586.667 µs) : 0, 587
Telemetry [baseline] (8.878 ms) : 0, 8878
Telemetry [candidate] (7.454 ms) : 0, 7454

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-30T12:04:38 2024-04-30T12:11:27
git_branch master nikita-tkachenko/selenium-about-blank
git_commit_date 1714472597 1714477123
git_commit_sha 2b0502c 948cedc
release_version 1.34.0-SNAPSHOT~2b0502cacf 1.34.0-SNAPSHOT~948cedc714
start_time 2024-04-30T12:04:25 2024-04-30T12:11:14
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714479434 1714479434
ci_job_id 500672057 500672057
ci_pipeline_id 33242272 33242272
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~948cedc714, baseline=1.34.0-SNAPSHOT~2b0502cacf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.341 ms) : 1322, 1360
.   : milestone, 1341,
appsec (1.73 ms) : 1706, 1753
.   : milestone, 1730,
appsec_no_iast (1.732 ms) : 1707, 1757
.   : milestone, 1732,
iast (1.486 ms) : 1463, 1508
.   : milestone, 1486,
profiling (1.523 ms) : 1497, 1549
.   : milestone, 1523,
tracing (1.455 ms) : 1431, 1478
.   : milestone, 1455,
section candidate
no_agent (1.344 ms) : 1325, 1363
.   : milestone, 1344,
appsec (1.732 ms) : 1708, 1756
.   : milestone, 1732,
appsec_no_iast (1.746 ms) : 1722, 1771
.   : milestone, 1746,
iast (1.493 ms) : 1470, 1516
.   : milestone, 1493,
profiling (1.568 ms) : 1543, 1592
.   : milestone, 1568,
tracing (1.478 ms) : 1453, 1502
.   : milestone, 1478,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.322 ms, 1.36 ms] -
appsec 1.73 ms [1.706 ms, 1.753 ms] 388.723 µs (29.0%)
appsec_no_iast 1.732 ms [1.707 ms, 1.757 ms] 390.767 µs (29.1%)
iast 1.486 ms [1.463 ms, 1.508 ms] 144.483 µs (10.8%)
profiling 1.523 ms [1.497 ms, 1.549 ms] 181.694 µs (13.5%)
tracing 1.455 ms [1.431 ms, 1.478 ms] 113.44 µs (8.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.325 ms, 1.363 ms] -
appsec 1.732 ms [1.708 ms, 1.756 ms] 387.881 µs (28.9%)
appsec_no_iast 1.746 ms [1.722 ms, 1.771 ms] 402.375 µs (29.9%)
iast 1.493 ms [1.47 ms, 1.516 ms] 148.839 µs (11.1%)
profiling 1.568 ms [1.543 ms, 1.592 ms] 223.559 µs (16.6%)
tracing 1.478 ms [1.453 ms, 1.502 ms] 133.532 µs (9.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~948cedc714, baseline=1.34.0-SNAPSHOT~2b0502cacf
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.427 µs) : 352, 392
.   : milestone, 372,
iast (478.635 µs) : 458, 499
.   : milestone, 479,
iast_FULL (546.317 µs) : 525, 567
.   : milestone, 546,
iast_GLOBAL (493.777 µs) : 473, 514
.   : milestone, 494,
iast_HARDCODED_SECRET_DISABLED (481.519 µs) : 460, 503
.   : milestone, 482,
iast_INACTIVE (455.463 µs) : 433, 477
.   : milestone, 455,
iast_TELEMETRY_OFF (477.728 µs) : 457, 499
.   : milestone, 478,
tracing (446.366 µs) : 425, 467
.   : milestone, 446,
section candidate
no_agent (366.491 µs) : 346, 387
.   : milestone, 366,
iast (477.546 µs) : 456, 499
.   : milestone, 478,
iast_FULL (548.113 µs) : 528, 569
.   : milestone, 548,
iast_GLOBAL (492.797 µs) : 472, 513
.   : milestone, 493,
iast_HARDCODED_SECRET_DISABLED (473.9 µs) : 453, 494
.   : milestone, 474,
iast_INACTIVE (454.784 µs) : 434, 475
.   : milestone, 455,
iast_TELEMETRY_OFF (469.45 µs) : 448, 491
.   : milestone, 469,
tracing (445.282 µs) : 425, 465
.   : milestone, 445,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.427 µs [352.385 µs, 392.469 µs] -
iast 478.635 µs [458.069 µs, 499.201 µs] 106.208 µs (28.5%)
iast_FULL 546.317 µs [525.208 µs, 567.426 µs] 173.89 µs (46.7%)
iast_GLOBAL 493.777 µs [473.39 µs, 514.164 µs] 121.35 µs (32.6%)
iast_HARDCODED_SECRET_DISABLED 481.519 µs [460.096 µs, 502.942 µs] 109.092 µs (29.3%)
iast_INACTIVE 455.463 µs [433.482 µs, 477.443 µs] 83.036 µs (22.3%)
iast_TELEMETRY_OFF 477.728 µs [456.831 µs, 498.625 µs] 105.3 µs (28.3%)
tracing 446.366 µs [425.31 µs, 467.423 µs] 73.939 µs (19.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.491 µs [346.366 µs, 386.616 µs] -
iast 477.546 µs [456.432 µs, 498.661 µs] 111.055 µs (30.3%)
iast_FULL 548.113 µs [527.574 µs, 568.651 µs] 181.622 µs (49.6%)
iast_GLOBAL 492.797 µs [472.283 µs, 513.31 µs] 126.305 µs (34.5%)
iast_HARDCODED_SECRET_DISABLED 473.9 µs [453.406 µs, 494.395 µs] 107.409 µs (29.3%)
iast_INACTIVE 454.784 µs [434.411 µs, 475.158 µs] 88.293 µs (24.1%)
iast_TELEMETRY_OFF 469.45 µs [448.394 µs, 490.506 µs] 102.959 µs (28.1%)
tracing 445.282 µs [425.136 µs, 465.428 µs] 78.791 µs (21.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/selenium-about-blank
git_commit_date 1714472597 1714477123
git_commit_sha 2b0502c 948cedc
release_version 1.34.0-SNAPSHOT~2b0502cacf 1.34.0-SNAPSHOT~948cedc714
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1714479930 1714479930
ci_job_id 500672058 500672058
ci_pipeline_id 33242272 33242272
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~948cedc714, baseline=1.34.0-SNAPSHOT~2b0502cacf
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.221 s) : 15221000, 15221000
.   : milestone, 15221000,
appsec (15.324 s) : 15324000, 15324000
.   : milestone, 15324000,
iast (18.764 s) : 18764000, 18764000
.   : milestone, 18764000,
iast_GLOBAL (17.87 s) : 17870000, 17870000
.   : milestone, 17870000,
profiling (15.05 s) : 15050000, 15050000
.   : milestone, 15050000,
tracing (15.258 s) : 15258000, 15258000
.   : milestone, 15258000,
section candidate
no_agent (14.981 s) : 14981000, 14981000
.   : milestone, 14981000,
appsec (14.951 s) : 14951000, 14951000
.   : milestone, 14951000,
iast (18.804 s) : 18804000, 18804000
.   : milestone, 18804000,
iast_GLOBAL (17.965 s) : 17965000, 17965000
.   : milestone, 17965000,
profiling (15.263 s) : 15263000, 15263000
.   : milestone, 15263000,
tracing (14.796 s) : 14796000, 14796000
.   : milestone, 14796000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.221 s [15.221 s, 15.221 s] -
appsec 15.324 s [15.324 s, 15.324 s] 103.0 ms (0.7%)
iast 18.764 s [18.764 s, 18.764 s] 3.543 s (23.3%)
iast_GLOBAL 17.87 s [17.87 s, 17.87 s] 2.649 s (17.4%)
profiling 15.05 s [15.05 s, 15.05 s] -171.0 ms (-1.1%)
tracing 15.258 s [15.258 s, 15.258 s] 37.0 ms (0.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.981 s [14.981 s, 14.981 s] -
appsec 14.951 s [14.951 s, 14.951 s] -30.0 ms (-0.2%)
iast 18.804 s [18.804 s, 18.804 s] 3.823 s (25.5%)
iast_GLOBAL 17.965 s [17.965 s, 17.965 s] 2.984 s (19.9%)
profiling 15.263 s [15.263 s, 15.263 s] 282.0 ms (1.9%)
tracing 14.796 s [14.796 s, 14.796 s] -185.0 ms (-1.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~948cedc714, baseline=1.34.0-SNAPSHOT~2b0502cacf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.209 ms) : 2175, 2243
.   : milestone, 2209,
iast (1.886 ms) : 1851, 1920
.   : milestone, 1886,
iast_GLOBAL (1.936 ms) : 1901, 1972
.   : milestone, 1936,
profiling (1.857 ms) : 1823, 1892
.   : milestone, 1857,
tracing (1.843 ms) : 1811, 1875
.   : milestone, 1843,
section candidate
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.206 ms) : 2172, 2240
.   : milestone, 2206,
iast (1.887 ms) : 1852, 1923
.   : milestone, 1887,
iast_GLOBAL (1.935 ms) : 1900, 1971
.   : milestone, 1935,
profiling (2.287 ms) : 2121, 2452
.   : milestone, 2287,
tracing (1.854 ms) : 1821, 1887
.   : milestone, 1854,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.209 ms [2.175 ms, 2.243 ms] 742.359 µs (50.6%)
iast 1.886 ms [1.851 ms, 1.92 ms] 418.706 µs (28.5%)
iast_GLOBAL 1.936 ms [1.901 ms, 1.972 ms] 469.566 µs (32.0%)
profiling 1.857 ms [1.823 ms, 1.892 ms] 390.456 µs (26.6%)
tracing 1.843 ms [1.811 ms, 1.875 ms] 376.017 µs (25.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.206 ms [2.172 ms, 2.24 ms] 739.344 µs (50.4%)
iast 1.887 ms [1.852 ms, 1.923 ms] 420.964 µs (28.7%)
iast_GLOBAL 1.935 ms [1.9 ms, 1.971 ms] 468.957 µs (32.0%)
profiling 2.287 ms [2.121 ms, 2.452 ms] 820.505 µs (56.0%)
tracing 1.854 ms [1.821 ms, 1.887 ms] 387.504 µs (26.4%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review April 30, 2024 12:57
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner April 30, 2024 12:57
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 98a0d09 into master May 3, 2024
82 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/selenium-about-blank branch May 3, 2024 10:04
@github-actions github-actions bot added this to the 1.34.0 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-fernandez juan-fernandez juan-fernandez approved these changes

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility type: bug
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.

BUG: dd-trace-java with version 1.33.0 causes InvalidCookieDomainException. In 1.32.0 works fine.
2 participants
@nikita-tkachenko-datadog @juan-fernandez