Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vert.X Redis client 4 instrumentation tests are flaky #6910

Open
PerfectSlayer opened this issue Apr 15, 2024 · 0 comments
Open

Vert.X Redis client 4 instrumentation tests are flaky #6910

PerfectSlayer opened this issue Apr 15, 2024 · 0 comments
Labels
inst: vertx Eclipse Vert.x instrumentation tag: flaky test Flaky tests

Comments

@PerfectSlayer
Copy link
Contributor

PerfectSlayer commented Apr 15, 2024

Test suite

linsert (5 args) from VertxRedisAPIRedisForkedTest
Marked flaky by CircleCI

Error

Condition not satisfied:

VertxRedisTestBase.parentTraceWithCommandAndHandler(VertxRedisTestBase.groovy:116)

assert trace.size() == expectedSize
| | | |
| 4 | 3
| false
[DDSpan [ t_id=58, s_id=57, p_id=0 ] trace=worker.org.gradle.process.internal.worker.GradleWorkerMain/parent/parent tags={_dd.agent_psr=1.0, _dd.profiling.ctx=test, _dd.profiling.enabled=0, _dd.trace_span_attribute_schema=0, _sample_rate=1, language=jvm, process_id=16841, runtime-id=5fe20e7a-e1a3-4f5d-bea2-c7b166591d39, thread.id=1, thread.name=Test worker}, duration_ns=17013879, forceKeep=false, links=[], DDSpan [ t_id=58, s_id=60, p_id=57 ] trace=worker.org.gradle.process.internal.worker.GradleWorkerMain/handler/handler tags={thread.id=1, thread.name=Test worker}, duration_ns=11710341, forceKeep=false, links=[], DDSpan [ t_id=58, s_id=61, p_id=57 ] trace=worker.org.gradle.process.internal.worker.GradleWorkerMain/handler/handler tags={thread.id=48, thread.name=vert.x-eventloop-thread-0}, duration_ns=11181787, forceKeep=false, links=[], DDSpan [ t_id=58, s_id=59, p_id=57 ] trace=redis/redis.query/LRANGE measured tags={_dd.base_service=worker.org.gradle.process.internal.worker.GradleWorkerMain, component=redis-command, db.type=redis, peer.hostname=localhost, peer.port=32790, span.kind=client, thread.id=1, thread.name=Test worker}, duration_ns=3071788, forceKeep=false, links=[]]

at datadog.trace.agent.test.asserts.ListWriterAssert.assertTraces(ListWriterAssert.groovy:90)
at datadog.trace.agent.test.asserts.ListWriterAssert.assertTraces(ListWriterAssert.groovy:41)
at datadog.trace.agent.test.AgentTestRunner.assertTraces(AgentTestRunner.groovy:600)
at datadog.trace.agent.test.AgentTestRunner.assertTraces(AgentTestRunner.groovy:589)
at VertxRedisAPITestBase.linsert (5 args)(VertxRedisAPITestBase.groovy:117)

Caused by: Assertion failed:

assert trace.size() == expectedSize
| | | |
| 4 | 3
| false
[DDSpan [ t_id=58, s_id=57, p_id=0 ] trace=worker.org.gradle.process.internal.worker.GradleWorkerMain/parent/parent tags={_dd.agent_psr=1.0, _dd.profiling.ctx=test, _dd.profiling.enabled=0, _dd.trace_span_attribute_schema=0, _sample_rate=1, language=jvm, process_id=16841, runtime-id=5fe20e7a-e1a3-4f5d-bea2-c7b166591d39, thread.id=1, thread.name=Test worker}, duration_ns=17013879, forceKeep=false, links=[], DDSpan [ t_id=58, s_id=60, p_id=57 ] trace=worker.org.gradle.process.internal.worker.GradleWorkerMain/handler/handler tags={thread.id=1, thread.name=Test worker}, duration_ns=11710341, forceKeep=false, links=[], DDSpan [ t_id=58, s_id=61, p_id=57 ] trace=worker.org.gradle.process.internal.worker.GradleWorkerMain/handler/handler tags={thread.id=48, thread.name=vert.x-eventloop-thread-0}, duration_ns=11181787, forceKeep=false, links=[], DDSpan [ t_id=58, s_id=59, p_id=57 ] trace=redis/redis.query/LRANGE measured tags={_dd.base_service=worker.org.gradle.process.internal.worker.GradleWorkerMain, component=redis-command, db.type=redis, peer.hostname=localhost, peer.port=32790, span.kind=client, thread.id=1, thread.name=Test worker}, duration_ns=3071788, forceKeep=false, links=[]]

at datadog.trace.agent.test.asserts.TraceAssert.assertTrace(TraceAssert.groovy:42)
at datadog.trace.agent.test.asserts.ListWriterAssert.trace(ListWriterAssert.groovy:124)
at VertxRedisTestBase.parentTraceWithCommandAndHandler(VertxRedisTestBase.groovy:116)
at VertxRedisAPITestBase.linsert (5 args)_closure16(VertxRedisAPITestBase.groovy:120)
at datadog.trace.agent.test.asserts.ListWriterAssert.assertTraces(ListWriterAssert.groovy:59)
... 4 more

Cause:
Expecting 4 spans but received 3.

Environment:
Java 21, instrumentation tests.

Logs:
redis4xForkedTest.zip

@PerfectSlayer PerfectSlayer added tag: flaky test Flaky tests inst: vertx Eclipse Vert.x instrumentation labels Apr 15, 2024
@PerfectSlayer PerfectSlayer changed the title Vert.X Redis client 3.9 instrumentation test is flaky Vert.X Redis client 4 instrumentation test is flaky Apr 15, 2024
PerfectSlayer added a commit that referenced this issue Apr 16, 2024
@PerfectSlayer PerfectSlayer changed the title Vert.X Redis client 4 instrumentation test is flaky Vert.X Redis client 4 instrumentation tests are flaky Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inst: vertx Eclipse Vert.x instrumentation tag: flaky test Flaky tests
Projects
None yet
Development

No branches or pull requests

1 participant