Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.{mod, sum}: update several modules to avoid security flaws #1330

Merged
merged 2 commits into from Jun 7, 2022

Conversation

knusbaum
Copy link
Contributor

@knusbaum knusbaum commented Jun 7, 2022

This commit updates: github.com/gogo/protobuf, github.com/valyala/fasthttp

These both had severe security issues in the versions listed in our go.mod
file. We are updating them here to ensure that dd-trace-go will never pull
a vulnerable dependency into a user's project.

This commit updates: github.com/gogo/protobuf github.com/valyala/fasthttp

These both had severe security issues in the versions listed in our go.mod
file. We are updating them here to ensure that ddd-trace-go will never pull
a vulnerable dependency into a user's project.
@knusbaum knusbaum added this to the 1.39.0 milestone Jun 7, 2022
@knusbaum knusbaum requested a review from a team as a code owner June 7, 2022 16:36
katiehockman
katiehockman previously approved these changes Jun 7, 2022
Copy link
Contributor

@katiehockman katiehockman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nsrip-dd
Copy link
Contributor

nsrip-dd commented Jun 7, 2022

Thanks Kyle! Looks like you need to do a go mod tidy, perhaps? I ran locally in the CI image and a go mod tidy was enough to fix the build errors.

@knusbaum knusbaum merged commit fb3a9d9 into main Jun 7, 2022
@knusbaum knusbaum deleted the knusbaum/security-bump branch June 7, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants