contrib/internal/httptrace: store client_ip in tags for backend WAF #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hellzy
force-pushed
the
francois.mazeau/backend-waf-client-ip
branch
from
94abde9
to
7a07462
Compare
Hellzy
force-pushed
the
francois.mazeau/backend-waf-client-ip
branch
2 times, most recently
from
3bfbd1d
to
0ebf5e7
Compare
Hellzy
force-pushed
the
francois.mazeau/backend-waf-client-ip
branch
from
0ebf5e7
to
3f48379
Compare
Hellzy
force-pushed
the
francois.mazeau/backend-waf-client-ip
branch
3 times, most recently
from
1fbc8d3
to
046d394
Compare
Hellzy
force-pushed
the
francois.mazeau/backend-waf-client-ip
branch
from
046d394
to
a56b30d
Compare
gbbr
suggested changes
Jun 9, 2022
Hellzy
force-pushed
the
francois.mazeau/backend-waf-client-ip
branch
from
c119d74
to
ca69977
Compare
Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
Hellzy
force-pushed
the
francois.mazeau/backend-waf-client-ip
branch
from
ca69977
to
adc7b28
Compare
gbbr
reviewed
Jun 10, 2022
- Improve code wrt style guidelines - Rework error checking in parseIP - Use net.SplitHostPort instead of local function - Minor nits
Hellzy
force-pushed
the
francois.mazeau/backend-waf-client-ip
branch
from
27aac5d
to
8b67d9e
Compare
gbbr
suggested changes
Jun 14, 2022
Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store client IP in tags for backend WAF
This set of changes parses the client IP by browsing through the request headers and stores the IP, if found, in the tags at span creation. This is needed for the ongoing effort to setup the backend WAF.
Client IP resolution RFC:
https://datadoghq.atlassian.net/wiki/spaces/APS/pages/2118779066/Client+IP+addresses+resolution
This also updates go.mod and go.sum since the changes use
inet.af/netaddr.