Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/internal/httptrace: set http.host tag on request Host not URL.host #1327

Merged
merged 4 commits into from Jun 6, 2022
Merged

contrib/internal/httptrace: set http.host tag on request Host not URL.host #1327

merged 4 commits into from Jun 6, 2022

Conversation

ajgajg1134
Copy link
Contributor

this fixes #1236

@ajgajg1134 ajgajg1134 added this to the 1.39.0 milestone Jun 6, 2022
@ajgajg1134 ajgajg1134 marked this pull request as ready for review June 6, 2022 17:07
@ajgajg1134 ajgajg1134 requested a review from a team June 6, 2022 17:07
dianashevchenko
dianashevchenko previously approved these changes Jun 6, 2022
View reviewed changes
@knusbaum
Copy link
Contributor

knusbaum commented Jun 6, 2022

Is there any way to add a simple test for this with httptest or something?

knusbaum
knusbaum approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the test.

@ajgajg1134 ajgajg1134 merged commit 5915aae into main Jun 6, 2022
@ajgajg1134 ajgajg1134 deleted the andrew.glaude/fixHttpHost branch June 6, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knusbaum knusbaum knusbaum approved these changes

@dianashevchenko dianashevchenko dianashevchenko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.39.0
Development

Successfully merging this pull request may close these issues.

proposal: Enhance http.host tag handling
3 participants
@ajgajg1134 @knusbaum @dianashevchenko