From 540a928b953aaebfce12a57766629aa47bf64c62 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20Geisend=C3=B6rfer?= Date: Mon, 16 May 2022 10:32:12 +0200 Subject: [PATCH] profiler: rename pid tag to process_id MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The profiler is tagging profiles with the "pid" tag whereas other Datadog products use a different tag – "process_id". Based on internal discussions, we decided to align on "process_id". See PROF-5111 for more details. --- profiler/options.go | 2 +- profiler/upload_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/profiler/options.go b/profiler/options.go index 8106b61531..fbe578fa65 100644 --- a/profiler/options.go +++ b/profiler/options.go @@ -204,7 +204,7 @@ func defaultConfig() (*config, error) { mutexFraction: DefaultMutexFraction, uploadTimeout: DefaultUploadTimeout, maxGoroutinesWait: 1000, // arbitrary value, should limit STW to ~30ms - tags: []string{fmt.Sprintf("pid:%d", os.Getpid())}, + tags: []string{fmt.Sprintf("process_id:%d", os.Getpid())}, deltaProfiles: internal.BoolEnv("DD_PROFILING_DELTA", true), logStartup: true, } diff --git a/profiler/upload_test.go b/profiler/upload_test.go index c1457fc817..27ceb2146f 100644 --- a/profiler/upload_test.go +++ b/profiler/upload_test.go @@ -71,7 +71,7 @@ func TestTryUpload(t *testing.T) { "env:my-env", "tag1:1", "tag2:2", - fmt.Sprintf("pid:%d", os.Getpid()), + fmt.Sprintf("process_id:%d", os.Getpid()), fmt.Sprintf("profiler_version:%s", version.Tag), fmt.Sprintf("runtime_version:%s", strings.TrimPrefix(runtime.Version(), "go")), fmt.Sprintf("runtime_compiler:%s", runtime.Compiler),