contrib: refactor http request span tags #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the start and finish of http request spans into functions shared across contribs so that the expected set of http request span tags are properly implemented.
gbbr
reviewed
May 11, 2022
Julio-Guerra
commented
May 11, 2022
Julio-Guerra
commented
May 12, 2022
gbbr
reviewed
May 12, 2022
gbbr
reviewed
May 12, 2022
gbbr
reviewed
May 12, 2022
gbbr
suggested changes
May 30, 2022
gbbr
reviewed
May 30, 2022
dianashevchenko
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the start and finish of http request spans into functions
shared across contribs so that the expected set of http request span
tags are properly implemented.
The new standard
http.useragentis added in this PR as a first example of span tag addition spread out to every HTTP integration.