Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: handle parent-id header of 0 for synthetics #1285

Merged
merged 2 commits into from May 18, 2022

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented May 10, 2022

Synthetic tests set the header x-datadog-parent-id to 0. Currently, the tracer mishandles this and considers that the span id is not set when it is 0.

This PR makes sure that header x-datadog-parent-id of value 0 is handled correctly when the origin is synthetics.

See APMGO-242

@mackjmr mackjmr requested a review from a team May 10, 2022 12:41
@dianashevchenko dianashevchenko added this to the 1.39.0 milestone May 10, 2022
@dianashevchenko dianashevchenko merged commit 528bd03 into v1 May 18, 2022
@dianashevchenko dianashevchenko deleted the mackjmr/synthetics-origin-parent-id branch May 18, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants