ddtrace/tracer: add WithUniversalVersion option #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed limitation of having service name match the name defined when starting the tracer for version tracking.
knusbaum
requested changes
May 3, 2022
|
I do not get this PR - title is saying that work is on WithServiceNameMatch and then code is changing WithUniversalVersion - can someone explain? |
dianashevchenko
changed the title
|
@xrn sorry for confusion, I updated the PR name. Since the change concerned setting version tag on the span, it was resolved to rename the option to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed limitation of having service name match the name defined when starting the tracer for version tracking.
Closes #1161