From f72716b44eb32c8c49757f7cb312e946defea452 Mon Sep 17 00:00:00 2001 From: Yulius Tjahjadi Date: Fri, 29 Apr 2022 08:01:20 -0700 Subject: [PATCH 1/2] aws: add request id to trace --- contrib/aws/aws-sdk-go/aws/aws.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/aws/aws-sdk-go/aws/aws.go b/contrib/aws/aws-sdk-go/aws/aws.go index 60557c4e4c..1a6dd59edc 100644 --- a/contrib/aws/aws-sdk-go/aws/aws.go +++ b/contrib/aws/aws-sdk-go/aws/aws.go @@ -24,6 +24,7 @@ const ( tagAWSOperation = "aws.operation" tagAWSRegion = "aws.region" tagAWSRetryCount = "aws.retry_count" + tagAWSRequestID = "aws.request_id" ) type handlers struct { @@ -78,6 +79,7 @@ func (h *handlers) Complete(req *request.Request) { return } span.SetTag(tagAWSRetryCount, req.RetryCount) + span.SetTag(tagAWSRequestID, req.RequestID) if req.HTTPResponse != nil { span.SetTag(ext.HTTPCode, strconv.Itoa(req.HTTPResponse.StatusCode)) } From 8827bac614e970addf64bef4fa2a5675e5a958a6 Mon Sep 17 00:00:00 2001 From: Yulius Tjahjadi Date: Fri, 29 Apr 2022 10:32:48 -0700 Subject: [PATCH 2/2] add request id unit test --- contrib/aws/aws-sdk-go/aws/aws_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/aws/aws-sdk-go/aws/aws_test.go b/contrib/aws/aws-sdk-go/aws/aws_test.go index 8a1906ea29..db4f0bfde6 100644 --- a/contrib/aws/aws-sdk-go/aws/aws_test.go +++ b/contrib/aws/aws-sdk-go/aws/aws_test.go @@ -57,6 +57,7 @@ func TestAWS(t *testing.T) { assert.Equal(t, "403", s.Tag(ext.HTTPCode)) assert.Equal(t, "PUT", s.Tag(ext.HTTPMethod)) assert.Equal(t, "http://s3.us-west-2.amazonaws.com/BUCKET", s.Tag(ext.HTTPURL)) + assert.NotNil(t, s.Tag(tagAWSRequestID)) }) t.Run("ec2", func(t *testing.T) {