New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/net/http: add dynamic resource naming #1142
contrib/net/http: add dynamic resource naming #1142
Conversation
This was built on v1.33 and I've been running it internally for a while. Looks like the main branch has moved ahead of me a bit and there's a conflict. |
Thanks for contributing this PR. The change is good, and will be accepted, but please reduce it only the what was discussed in the issue. |
@jcogilvie |
Resource namer
@gbbr The tests are passing on my code but failing on the tag, and I'm not sure what action I am expected to take. Otherwise I think I have addressed all of your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small nit.
Accept suggestion. Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks!
@gbbr this was approved; can we get it merged? |
@jcogilvie please rebase to pass the checks and we'll merge 🙌 |
@dianashevchenko it's unclear to me how to make the tag test pass in |
@jcogilvie, Those aren't your fault, the latest release hasn't been merged back into the v1 branch just yet which means the version number is mismatched on this PR. Once #1253 is merged you can rebase onto that change (there shouldn't be any conflicts) and everything will pass |
@jcogilvie the version number PR is merged, you can rebase now 👍 |
@dianashevchenko can we merge this yet? Seems like the goalposts keep moving. |
Fixes #983.