Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update DataDog/sketches-go to 1.2.1 #1051

Merged
merged 2 commits into from May 16, 2022

Conversation

knusbaum
Copy link
Contributor

sketches-go@v1.0.0 contains some bugs which are fixed in v1.2.1

Fixes #1021

@knusbaum knusbaum added this to the 1.35.0 milestone Nov 12, 2021
@knusbaum
Copy link
Contributor Author

Well, we've found our first direct dependency that's incompatible with go1.12. github.com/DataDog/sketches-go@v1.2.1 uses binary literals, which were introduced in go1.13.

This raises the question of whether we should continue to support go1.12. I'm 👍 on dropping support since go1.12 lost official support when go1.14 was released in Feb 2020 (almost 2 years ago). It looks like we only need to bump it to go1.13 if we want to keep broad version support.

Honestly, I'm surprised we've managed to keep as much backward-compatibility as we have for as long as we have.
Would like to hear comments from @gbbr and @felixge.

felixge
felixge previously approved these changes Nov 14, 2021
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As far as go version support is concerned: I'm voting for only supporting Go versions that are officially supported by the Go team. People who want to use old Go versions can use old versions of dd-trace-go and we can add a table to the README that show what go versions work with what version of dd-trace-go.

If we ever get a customer that is unable to upgrade Go but still needs some dd-trace-go bug fixed in an old version, we could always backport a fix and make a minor release for them.

gbbr
gbbr previously approved these changes Dec 17, 2021
Julio-Guerra
Julio-Guerra previously approved these changes Mar 9, 2022
@Julio-Guerra
Copy link
Contributor

My bad, I thought this was mergeable but the question of supporting go1.12 is still opened here.

@Julio-Guerra Julio-Guerra modified the milestones: 1.37.0, 1.38.0 Mar 9, 2022
@Julio-Guerra Julio-Guerra modified the milestones: 1.38.0, Triage Apr 15, 2022
@knusbaum knusbaum closed this May 5, 2022
@knusbaum knusbaum force-pushed the knusbaum/bump-sketches-go branch from cbf7f04 to 1c53df5 Compare May 5, 2022 15:26
sketches-go@v1.0.0 contains some bugs which are fixed in v1.2.1

Fixes #1021
@dianashevchenko dianashevchenko modified the milestones: Triage, 1.39.0 May 16, 2022
@dianashevchenko dianashevchenko merged commit 9202227 into v1 May 16, 2022
@dianashevchenko dianashevchenko deleted the knusbaum/bump-sketches-go branch May 16, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sketches-go to latest version to resolve swag init issues
5 participants