[BUG] unable to extract traceparent header

[tylerbrewer2]

I'm attempting to create a span from an Opentelemetry trace id using the ddtrace Go library. It doesn't look like the library is parsing my traceparent header correctly. I've searched for more documentation around this and couldnt find any, although I could be missing it.

Here is my simplified code:

sctx, _ := tracer.Extract(tracer.HTTPHeadersCarrier(header))
span := tracer.StartSpan(operation, tracer.ChildOf(sctx))
logger.Info(fmt.Sprintf("Span Trace ID: %d", span.Context().TraceID())) // this will always be 0

And here is an example traceparent header: 00-5561fab7902a8debd3e3ae2dd534e52d-824e6ffb17187dcd-00

Version of dd-trace-go
1.59.0

Describe what happened:
The created span is not associated with the parent span.

Describe what you expected:
The created span to be associated with the parent span.

[darccio]

@tylerbrewer2 How is your header value looking?

[tylerbrewer2]

Here are my headers:

Sec-Fetch-Mode: cors
Accept-Encoding: gzip, deflate
Content-Length: 0
Host: 127.0.0.1:8090
Connection: keep-alive
Traceparent: 00-e73ce4a976cb18ac8d648239cc60e26f-ee91c28519b9f401-01
Accept: */*
Content-Type: application/proto
Accept-Language: *
User-Agent: undici

[darccio]

@tylerbrewer2 I just tested it in our current main branch, and it seems to work.

func TestHTTPHeadersCarrierExtract(t *testing.T) {
	tracer := newTracer()
	internal.SetGlobalTracer(tracer)
	defer tracer.Stop()
	r := &http.Request{
		Header: http.Header{
			"Sec-Fetch-Mode":  []string{"cors"},
			"Accept-Encoding": []string{"gzip, deflate"},
			"Content-Length":  []string{"0"},
			"Host":            []string{"127.0.0.1:8090"},
			"Connection":      []string{"keep-alive"},
			"Traceparent":     []string{"00-e73ce4a976cb18ac8d648239cc60e26f-ee91c28519b9f401-01"},
			"Accept":          []string{"*/*"},
			"Content-Type":    []string{"application/proto"},
			"Accept-Language": []string{"*"},
			"User-Agent":      []string{"undici"},
		},
	}
	header := HTTPHeadersCarrier(r.Header)
	sCtx, _ := Extract(header)
	span := StartSpan("operation", ChildOf(sCtx))
	assertions := assert.New(t)
	sp, ok := span.Context().(ddtrace.SpanContextW3C)
	assertions.True(ok)
	assertions.NotZero(sp.TraceID128())
	t.Logf("traceID: %s", sp.TraceID128())
}

Do you observe any difference between my example and your code?