Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push memory profiler when rss rapidly increase #2446

Open
zdyj3170101136 opened this issue Dec 19, 2023 · 3 comments
Open

push memory profiler when rss rapidly increase #2446

zdyj3170101136 opened this issue Dec 19, 2023 · 3 comments
Labels
enhancement quick change/addition that does not need full team approval profiler

Comments

@zdyj3170101136
Copy link

the agent could push memory profiler immediately when rss rapidly increase.

like:
https://github.com/mosn/holmes

@zdyj3170101136 zdyj3170101136 added the enhancement quick change/addition that does not need full team approval label Dec 19, 2023
@zdyj3170101136
Copy link
Author

@felixge could you check it?

@felixge
Copy link
Member

felixge commented Dec 29, 2023

Do you want this for the datadog-agent or when using dd-trace-go in your own applications?

Have you used holmes successfully in the past? If yes, for which use case? OOMs?

@zdyj3170101136
Copy link
Author

https://github.com/mosn/holmes

dd-trace-go on my own applications.

no, just a proposal.

now, per minute push of memory profiler is not enough for oom, especially for pod.

the k8s pod memory = rss + cache (not accurate.).

if a pod oom killed.

1, caused by rss memory. we could push a immediately memory profiler if memory rapidly increase to debug that.

2, caused by high cache memory.may be the dd-trace-go could provide some information on how to debug that.
use linux syscall mincore to get file cached memory.
2.1, check all file open by pid first, like log ~.
2.2, check all file in the pid file directory /root/pid/root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement quick change/addition that does not need full team approval profiler
Projects
None yet
Development

No branches or pull requests

3 participants