Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/internal/httptrace: Add DD_TRACE_SET_HTTP_ERROR_DISABLED env var #2432

Closed
wants to merge 1 commit into from
Closed

contrib/internal/httptrace: Add DD_TRACE_SET_HTTP_ERROR_DISABLED env var #2432

wants to merge 1 commit into from

Conversation

kazukousen
Copy link

What does this PR do?

Fixes #2390

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@kazukousen kazukousen requested a review from a team December 13, 2023 15:05
@kazukousen
contrib/internal/httptrace: Add DD_TRACE_SET_HTTP_ERROR_DISABLED env var
17635bf 
Signed-off-by: kazukousen <mmchari.0228@gmail.com>
@kazukousen kazukousen mentioned this pull request Dec 20, 2023
Open
@katiehockman katiehockman added the apm:ecosystem contrib/* related feature requests or bugs label Dec 20, 2023
@kazukousen
Copy link
Author

@ajgajg1134 @katiehockman I would highly appreciate if you could review it. thanks.

@kazukousen kazukousen closed this Jan 18, 2024
@darccio darccio mentioned this pull request Jan 19, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contrib/internal/httptrace: proposal: Add option to ignore setting errors for 5xx HTTP status codes
2 participants
@kazukousen @katiehockman