proposal: ddtrace/tracer: check for nil pointer in interface. #2029
Labels
ack
needs-investigation
requires work from team member
proposal
more in depth change that requires full team approval
tracer
Version of dd-trace-go
Describe what happened:
This is going to crash
the problem is in
https://github.com/DataDog/dd-trace-go/blob/v1.51.0/ddtrace/tracer/span.go#L427
instead of
if cfg.Error != nil
it should be something like
if !reflect.ValueOf(cfg.Error).IsNil()
Describe what you expected:
expected not to set error in the span.
Steps to reproduce the issue:
Additional environment details (Version of Go, Operating System, etc.):
The text was updated successfully, but these errors were encountered: