Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: upgrade remoteconfig/state to v0.42.0-rc.1 #1620

Merged
merged 2 commits into from Dec 13, 2022
Merged

go.mod: upgrade remoteconfig/state to v0.42.0-rc.1 #1620

merged 2 commits into from Dec 13, 2022

Conversation

Julio-Guerra
Copy link
Contributor

@Julio-Guerra Julio-Guerra commented Dec 13, 2022 •
edited

What does this PR do?

Closes #1607 (again)

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@Julio-Guerra Julio-Guerra requested a review from a team as a code owner December 13, 2022 16:50
@Julio-Guerra Julio-Guerra added this to the v1.45.0 milestone Dec 13, 2022
ajgajg1134
ajgajg1134 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pr-commenter
Copy link

pr-commenter bot commented Dec 13, 2022 •
edited

Benchmarks

Comparing candidate commit 2be0324 in PR branch julio.guerra/upgrade-agent-rc-version with baseline commit 37d378b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@Julio-Guerra Julio-Guerra merged commit 7064039 into main Dec 13, 2022
@Julio-Guerra Julio-Guerra deleted the julio.guerra/upgrade-agent-rc-version branch December 13, 2022 20:55
katiehockman pushed a commit that referenced this pull request Dec 14, 2022
@Julio-Guerra @katiehockman
[go.mod] upgrade remoteconfig/state to v0.42.0-rc.1 (#1620)
4226ad3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.45.0
Development

Successfully merging this pull request may close these issues.

[BUG] v1.44.0 seems to pull in a broken pkg
2 participants
@Julio-Guerra @ajgajg1134