Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: Fixes memory leak for spankind and component #1618

Merged
merged 4 commits into from Dec 13, 2022
Merged

contrib: Fixes memory leak for spankind and component #1618

merged 4 commits into from Dec 13, 2022

Conversation

zarirhamza
Copy link
Contributor

What does this PR do?

Fixes memory leak by calling span.kind and component unnecessarily in several integrations

@pr-commenter
Copy link

pr-commenter bot commented Dec 12, 2022 •
edited

Benchmarks

Comparing candidate commit b4a5e4a in PR branch zarir/contrib-mem-leak-fix with baseline commit 2790627 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@zarirhamza zarirhamza added this to the v1.44.0 milestone Dec 12, 2022
@zarirhamza
Copy link
Contributor Author

Need to run in reliability-environments to test for memory leaks before merging.

@zarirhamza zarirhamza marked this pull request as ready for review December 12, 2022 23:08
@zarirhamza zarirhamza requested a review from a team December 12, 2022 23:08
@ajgajg1134 ajgajg1134 modified the milestones: v1.44.0, v1.45.0 Dec 13, 2022
Julio-Guerra
Julio-Guerra previously approved these changes Dec 13, 2022
View reviewed changes
ajgajg1134
ajgajg1134 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks!!

@ajgajg1134 ajgajg1134 merged commit 37d378b into main Dec 13, 2022
@ajgajg1134 ajgajg1134 deleted the zarir/contrib-mem-leak-fix branch December 13, 2022 17:01
katiehockman pushed a commit that referenced this pull request Dec 14, 2022
@zarirhamza @katiehockman
contrib: Fixes memory leak for spankind and component (#1618)
4639183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes

@Julio-Guerra Julio-Guerra Julio-Guerra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.45.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zarirhamza @Julio-Guerra @ajgajg1134