appsec: report http.client_ip only when appsec is enabled #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julio-Guerra
changed the title
Julio-Guerra
approved these changes
Oct 24, 2022
Julio-Guerra
added a commit
that referenced
this pull request
Oct 25, 2022
Co-authored-by: Julio Guerra <julio@datadog.com>
|
Now backported into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The span tag
http.client_ipshouldn't be reported by default by APM alone, but rather be an ASM-only feature as part of the security monitoring data that ASM collects.This PR completely removes
http.client_ipfrom the APM contribs, and rather moves it back into the ASM's HTTP middlewares.System-tests properly cover the following cases:
http.client_ipis never not reported: https://github.com/DataDog/system-tests/blob/main/scenarios/appsec/test_client_ip.py#L17http.client_ipalways reported - with or without an attack: https://github.com/DataDog/system-tests/blob/main/tests/test_standard_tags.py#L166