contrib/internal/httptrace uses "inet.af/netaddr" which in turns imports go4.org/unsafe/assume-no-moving-gc

[mrkagelui]

Hi,

My app failed the test on the recent Go 1.19 because of go4.org/unsafe/assume-no-moving-gc, or rather because the current version used in this lib is not the latest, kindly check history of https://github.com/go4org/unsafe-assume-no-moving-gc/blob/main/untested.go for more info.

Here's part of my go mod why:

# go4.org/unsafe/assume-no-moving-gc
...
gopkg.in/DataDog/dd-trace-go.v1/contrib/net/http
gopkg.in/DataDog/dd-trace-go.v1/contrib/internal/httptrace
inet.af/netaddr
go4.org/intern
go4.org/unsafe/assume-no-moving-gc

My question is: why is inet.af/netaddr used instead of the standard package "net"?

If we really need it, could we upgrade to the latest "inet.af/netaddr" to use the latest unsafe package? ref: inetaf/netaddr@377050f

[Hellzy]

Hi @mrkagelui

My question is: why is inet.af/netaddr used instead of the standard package "net"?

This package has several features that are interesting to us that std "net" doesn't have.
An example: #1328 (comment).

I'd say let's go ahead with the upgrade.

[mrkagelui]

thank you for the answer, will read

[Hellzy]

#1406 was merged, closing. Thanks for this @mrkagelui.

[hbagdi]

Is there a release planned including this fix?

[mrkagelui]

Is there a release planned including this fix?

I think there's a milestone in that associated PR that says 1.41.0

[hbagdi]

I'm not very familiar with this repository's development and release timelines.
Is it possible to get this shipped as part of the patch release?
We want to move to Go 1.19 and this issue holds that up. This is the last blocker for us and possibly others in the community.

[nsrip-dd]

We have tagged a release candidate for v1.41.0 which contains this fix:

go get gopkg.in/DataDog/dd-trace-go.v1@v1.41.0-rc.1

The full release should be out by the end of the week

[hbagdi]

Sweet. Thanks!

[mrkagelui]

I'm not very familiar with this repository's development and release timelines. Is it possible to get this shipped as part of the patch release? We want to move to Go 1.19 and this issue holds that up. This is the last blocker for us and possibly others in the community.

an alternative is to force upgrade, go get -u inet.af/netaddr