Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update github.com/gin-gonic/gin to v1.7.7 (#1341) #1361

Merged
merged 1 commit into from Jun 30, 2022

Conversation

nsrip-dd
Copy link
Contributor

See https://github.com/gin-gonic/gin/releases/tag/v1.7.7, resolves a
vulnerability. This is a direct dependency as a library for which we
provide an integration and should be updated according to our version
policy to address the vulnerability.

See https://github.com/gin-gonic/gin/releases/tag/v1.7.7, resolves a
vulnerability. This is a direct dependency as a library for which we
provide an integration and should be updated according to our version
policy to address the vulnerability.
@nsrip-dd nsrip-dd requested a review from a team as a code owner June 28, 2022 16:42
@nsrip-dd nsrip-dd added this to the 1.39.0 milestone Jun 28, 2022
@nsrip-dd
Copy link
Contributor Author

This is cherry picked from main (see #1341). Let me know if I did this correctly!

Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me! Although it appears some of the log tests are failing? At first glance it looks like it's because this is branch is marked as version v1.39.0-rc.1 and the regex for version matching being used doesn't appear to like -rc.1

@nsrip-dd
Copy link
Contributor Author

Yeah, the failing tests are all due to the version not matching a regex. Should we just merge anyway?

@ajgajg1134
Copy link
Contributor

Yeah we can merge this anyways, I'll make a note to update the regex though since we'll have more -rc.x style versions in the future and that shouldn't make the test fail

@ajgajg1134 ajgajg1134 modified the milestones: 1.39.0, 1.40.0 Jun 30, 2022
@nsrip-dd nsrip-dd merged commit 61125ac into release-v1.39.x Jun 30, 2022
@nsrip-dd nsrip-dd deleted the gin-gonic-upgrade branch June 30, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants