ddtrace/tracer: address race detector warning from TestDefaultHTTPClient #1347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a deep comparision (through
assert.Equal
/assert.NotEqual
) of*http.Client
s in these tests can trigger a race detector warning:This is a data race but not actually a bug in the tracer library, just a bug in
the tests. We can use
assert.Same
/assert.NotSame
to compare the*http.Client
s as pointers, since the tests are just checking whether or notthe default client is returned.