Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update github.com/gin-gonic/gin to v1.7.7 #1341

Merged
merged 2 commits into from Jun 28, 2022

Conversation

nsrip-dd
Copy link
Contributor

@nsrip-dd nsrip-dd commented Jun 15, 2022

See https://github.com/gin-gonic/gin/releases/tag/v1.7.7, resolves a
vulnerability. This is a direct dependency as a library for which we
provide an integration and should be updated according to our version
policy to address the vulnerability.

Resolves #1340.

See https://github.com/gin-gonic/gin/releases/tag/v1.7.7, resolves a
vulnerability. This is a direct dependency as a library for which we
provide an integration and should be updated according to our version
policy to address the vulnerability.
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do you want to create a separate PR to merge into the v1.39.0 release branch? Or move this to the next version after that?

@nsrip-dd
Copy link
Contributor Author

Sure, it would be nice to get this in the release if I can. How do I do that?

@ajgajg1134
Copy link
Contributor

Sure, it would be nice to get this in the release if I can. How do I do that?

So if I understand the new branching strategy it means you'll want to merge to main here then open a new pull request that brings across this change into release/v1.39.x (You can probably just make a branch and cherry-pick the merge commit on to it)

@nsrip-dd nsrip-dd merged commit 2ff1841 into main Jun 28, 2022
@nsrip-dd nsrip-dd deleted the nick.ripley/gonic-upgrade branch June 28, 2022 16:07
nsrip-dd added a commit that referenced this pull request Jun 28, 2022
See https://github.com/gin-gonic/gin/releases/tag/v1.7.7, resolves a
vulnerability. This is a direct dependency as a library for which we
provide an integration and should be updated according to our version
policy to address the vulnerability.
nsrip-dd added a commit that referenced this pull request Jun 30, 2022
See https://github.com/gin-gonic/gin/releases/tag/v1.7.7, resolves a
vulnerability. This is a direct dependency as a library for which we
provide an integration and should be updated according to our version
policy to address the vulnerability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go.mod: upgrade gin-gonic to latest version to avoid vulnerability
2 participants