Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When DD_AGENT_HOST is set, tracer ignores WithAgentAddr start option #1280

Closed
alexbolgov opened this issue May 4, 2022 · 1 comment
Closed

When DD_AGENT_HOST is set, tracer ignores WithAgentAddr start option #1280

alexbolgov opened this issue May 4, 2022 · 1 comment

Comments

@alexbolgov
Copy link

alexbolgov commented May 4, 2022 •
edited

Hello!

WithAgentAddr is supposed to set agent address, but environment variable DD_AGENT_HOST takes precedence and WithAgentAddr option is ignored

This behaviour is not consistent with behaviour of other pairs of environment variables and StartOptions: for most (if not all) pairs of StartOption + env, the StartOption takes precedence.

A proposed change is to let WithAgentAddr to take precedence over DD_AGENT_HOST
@dianashevchenko
Copy link
Contributor

@alexbolgov it was addressed in #1232, will be in the next release 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexbolgov @dianashevchenko