ddtrace/tracer: add SetUser function and userTagOption #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hellzy
force-pushed
the
francois.mazeau/user-monitoring-sdk
branch
from
89172ec
to
33c9ba2
Compare
Julio-Guerra
reviewed
Mar 2, 2022
Julio-Guerra
reviewed
Mar 2, 2022
Julio-Guerra
reviewed
Mar 2, 2022
- Change UserTagOption to UserMonitoringOption - Options now return a closure that sets the tag directly - Improve comments - SetUser new sets the tags even if span type assertion fails
Hellzy
force-pushed
the
francois.mazeau/user-monitoring-sdk
branch
from
2cacd2c
to
62a610e
Compare
knusbaum
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identity monitoring
Summary
The purpose of this change is to add an SDK to allow tracer users to identify the user for a specific trace, i.e who made the request. To do so, we expose the
SetUserfunction that is in charge of adding tags holding authenticated user information to the root span of a trace.Said tags hold for example user name, e-mail address, permissions, etc...
RFC: https://docs.google.com/document/d/15dxIrx4D2BM3eUnLNCdMZjN4fQHlzISq31H6RiWRmIM
Changes
UserMonitoringOptionand severalWithXfunctions to generate options forSetUserSetUserfunction that rewinds back to the root span of the trace and adds the tags provided as parametersTestUserMonitoringtest to coverSetUseruse case (root + nested spans cases)