Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiler: Inc DefaultBlockRate from 10µs to 100ms #1192

Merged
merged 3 commits into from Mar 1, 2022
Merged

profiler: Inc DefaultBlockRate from 10µs to 100ms #1192

merged 3 commits into from Mar 1, 2022

Conversation

felixge
Copy link
Member

@felixge felixge commented Mar 1, 2022

@felixge felixge requested a review from a team as a code owner March 1, 2022 14:16
nsrip-dd
nsrip-dd requested changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only one change needed due to the Go 1.12 tests.

profiler/options.go Outdated Show resolved Hide resolved
@nsrip-dd nsrip-dd added this to the 1.37.0 milestone Mar 1, 2022
@nsrip-dd nsrip-dd merged commit 07c5508 into v1 Mar 1, 2022
@nsrip-dd nsrip-dd deleted the felix.geisendoerfer/increase-block-profiler-rate branch March 1, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsrip-dd nsrip-dd nsrip-dd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixge @nsrip-dd