internal/appsec/waf: remove appsec rule size limitations (#1189) #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of the WAF rules were limited like regular WAF values, leading to truncated WAF rules. This patch changes the limits to the max int values when encoding the WAF rules. It is considered a simpler change to achieve compared to the introduction of new "disabled limit" values that would have introduced more advanced and complex conditions in the encoder.
Hellzy
approved these changes
Mar 1, 2022
Julio-Guerra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the WAF rules were limited like regular WAF values, leading
to truncated WAF rules. This patch changes the limits to the max int
values when encoding the WAF rules. It is considered a simpler change
to achieve compared to the introduction of new "disabled limit" values
that would have introduced more advanced and complex conditions in the
encoder.