profiler: don't upload full profiles if delta profiling is enabled #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The full heap, mutex, and block profiles are not needed when delta profiling is enabled. Removing them (especially the full heap profile) results in a significant bandwidth and storage cost reduction.
felixge
previously approved these changes
Mar 1, 2022
Removed a redundant condition (deltaProfile is documented to return nil if delta profiles are disabled) and changed the order of conditions to match the default configuration (detla profiles first).
felixge
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
LGTM!
The only last thought I have is that:
func (p *profiler) runProfile(pt ProfileType) ([]*profile, error) {
Could probably be simplified to this now:
func (p *profiler) runProfile(pt ProfileType) (*profile, error) {
IIRC that's what the func signature looked like before I introduced delta profiles.
But I'm totally fine with doing that at some point in the future to keep this PR more tight and focused. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full heap, mutex, and block profiles are not needed when delta profiling is enabled. Removing them (especially the full heap profile) results in a significant bandwidth and storage cost reduction.
I have tested actually uploading profiles with this change (using a Datadog free trial) and can confirm that continuous profiling still works as expected. I can access the heap, block, and mutex profiles like normal. I just don't get "heap.pprof", etc. when I download the profiles.