Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: disable Datadog internal tag propagation #1182

Merged

Conversation

Barbayar
Copy link
Contributor

@Barbayar Barbayar commented Feb 24, 2022

The feature will be redesigned. It is still not used by the backend so there is no drawback in disabling it.

@Barbayar Barbayar requested a review from a team February 24, 2022 23:06
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ddtrace/tracer/tracer_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just delete this code?
We can always bring it back when we know what the fix will be. Right now we don't know what the solution will be or when it will happen.

@Barbayar Barbayar force-pushed the barbayar.dashzeveg/disables-datadog-internal-tag-propagation branch from b81fbe9 to cb56880 Compare February 25, 2022 09:15
@knusbaum knusbaum added this to the 1.37.0 milestone Feb 25, 2022
@knusbaum knusbaum changed the title Disables Datadog internal tag propagation ddtrace/tracer: disable Datadog internal tag propagation Feb 25, 2022
@knusbaum knusbaum merged commit 4f0b6ac into v1 Feb 25, 2022
@knusbaum knusbaum deleted the barbayar.dashzeveg/disables-datadog-internal-tag-propagation branch February 25, 2022 16:57
knusbaum pushed a commit that referenced this pull request Mar 1, 2022
This commit reverts part of:
ddtrace/tracer: propagate _dd.p.upstream_services tags #1082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants